feat(rover): collapse profile commands into config #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
requested review from
JakeDawkins and
lrlna
as code owners
EverlastingBugstopper
added
status - needs review
feature 🎉
`rover config {clear,profile} {auth,delete,list,show}` is dead,
long live `rover config {auth,clear,delete,list,show}`.
also did a quick cleanup of some help text and added a shortlink
for more info on API keys. waiting on merge of [this PR] for that to go live.
[this PR]: https://github.com/apollographql/shortlinks/pull/13
EverlastingBugstopper
force-pushed
the
avery/squash-config
branch
from
4fb93fb
to
8e5451a
Compare
JakeDawkins
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in short:
rover config {clear,profile} {auth,delete,list,show}has becomerover config {auth,clear,delete,list,show}.we had talked about doing this for a while and there seemed to be general consensus that keeping
rover [noun] [verb]was desirable, and the nesting under theprofilesubcommand was undesirable.also did a quick cleanup of some help text and added a shortlink
for more info on API keys. waiting on merge of this PR for that to go live.