Add --graph-ref flag to rover dev
#1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/command/dev/mod.rs
Outdated
| @@ -86,6 +92,19 @@ pub struct SupergraphOpts { | |||
| conflicts_with_all = ["subgraph_name", "subgraph_url", "subgraph_schema_path"] | |||
| )] | |||
| supergraph_config_path: Option<Utf8PathBuf>, | |||
|
|
|||
| /// A graph ref that is accessible in Apollo Studio. | |||
There was a problem hiding this comment.
graphRef? or, maybe graph reference? I don't know how common graph ref is outside of apollo
aaronArinder
approved these changes
Jul 15, 2024
jonathanrainer
added
the
feature 🎉
dotdat
force-pushed
the
dotdat/rover-dev-graphref
branch
from
42a18c7
to
08b4a77
Compare
Merged
jonathanrainer
added a commit
that referenced
this pull request
Jul 22, 2024
# [0.25.0] - 2024-07-22 ## 🚀 Features - **Enable Retries For Transient Errors Connecting To Graphs/Subgraphs - @jonathanrainer PR #1936** This turns on retries at the HTTP level for connections to graphs/subgraphs to minimize connection resets and cancellations. Also, a new --subgraph-retries flag for rover dev lets you set the number of retries allowed when trying to re-establish a connection. - **Add `--graph-ref` flag to `rover dev` - @dotdat PR #1984** Introduces subgraph mirroring to rover dev. Subgraph mirroring inherits the subgraph routing URLs and schemas from an existing Studio graphref. This makes it easy to spin up a locally running supergraph without maintaining a supergraph config. [See here](https://www.apollographql.com/docs/rover/commands/dev#starting-a-session-from-a-graphos-studio-variant) for more information. ## 🐛 Fixes - **Fixes issues related to passing filenames to `--output` - @jonathanrainer PR #1996** An issue was raised whereby previous versions of Rover supported passing filenames to the `--output` flag but this was broken in v0.24.0. This has now been fixed and the previous functionality restored. ## 🛠 Maintenance - **Expand Smoke Tests To Run On All Supported Platforms - @jonathanrainer PR #1980** - **Fix cron expression, so it runs only once per day - @jonathanrainer PR #1986** - **Ensure we always use the correct version of Federation when testing - @jonathanrainer PR #1987** - **Add manual Smoke test invocation and pin Windows to `npm@9` for testing - @jonathanrainer PR #1989** - **Update apollographql/router to v1.51.0 - @jonathanrainer PR #1988** - **Update node.js packages - @jonathanrainer PR #1979** Includes `@eslint/compat` to v1.1.1, `eslint` to v9.7.0, `node.js` to v20.15.1, `npm` to v10.8.2 and `prettier` to v3.3.3 - **Make sure x86 Mac Tests use 'latest' supergraph plugin version - @jonathanrainer PR #1990** - **Make sure homebrew runs `brew update` when we use it - @jonathanrainer PR #1993** ## 📚 Documentation - **Adds `graph-ref` flag to dev subcommand docs - @jackonawalk PR #1945** - **Update schema proposals capabilities docs - @Meschreiber PR #1949**
aaronArinder
pushed a commit
that referenced
this pull request
Aug 1, 2024
**NOTE: This should not be merged until #1874 has been merged, and then this rebased on top** In #1984 we added support to pass a `--graph-ref` flag to `rover dev`. Since `supergraph compose` is performing the same function as `rover dev` it makes sense to expose the same option there too. However, this requires some refactoring in order to make work. In principle the idea is fairly simple, we should centralise the construction of the SupergraphConfig object so that both `dev` and `supergraph compose` can hook in to it from a central location. However to do this I've also had to add a fair amount of testing because there was very little coverage in this area, however, due to @dotdat's work on #1977 we have a lot more test coverage than before. That work has been integrated into this PR. Further more @dotdat was working on another PR #1985 , which optimises the calls made by the `--graph-ref` option to fetch subgraphs in one request rather than multiple. Due to being in this area and working on the `--graph-ref` option it also made sense to integrate that PR here as well, to prevent a complicated rebase later on. This PR has been tested by the addition of unit tests and running `supergraph compose` locally. _There is also a small change to `deny.toml` in this PR to add support for BSD-2-Clause licences. We already support BSD-3-Clause, and 2-Clause is strictly a subset so this should not be a problem_
This was referenced Sep 11, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--graph-reftorover devwhich builds aSupergraphConfigfrom Apollo Studio and optionally overrides its values with a suppliedsupergraph.yamlRelated Issue: #1494