chore: install volta via chocolatey instead of flaky MSI installer #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
changed the title
EverlastingBugstopper
changed the title
EverlastingBugstopper
changed the title
EverlastingBugstopper
requested review from
glasser,
abernix,
krachwal,
trevor-scheer and
dbanty
glasser
approved these changes
Aug 21, 2023
.circleci/config.yml
Outdated
| - unless: | ||
| condition: | ||
| equal: [*arm_ubuntu_executor, << parameters.platform >>] | ||
| or: |
There was a problem hiding this comment.
This change seems to not do much?
There was a problem hiding this comment.
thanks for the catch - this was leftover from my (many) trial and error commits
dbanty
approved these changes
Aug 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volta installs have been flaky on windows for a while and I hope this PR fixes that.
I've updated our install method from the MSI that they provide to a direct download via the package manager chocolatey.