-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rover persisted-queries publish
#1599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
added
feature 🎉
new commands, flags, functionality, and improved error messages
blocked ⚠️
labels
May 16, 2023
EverlastingBugstopper
changed the title
feat: persisted queries
feat: May 16, 2023
rover persisted-queries publish
glasser
reviewed
May 31, 2023
crates/rover-client/src/operations/persisted_queries/describe_pql/describe_pql_query.graphql
Outdated
Show resolved
Hide resolved
crates/rover-client/src/operations/persisted_queries/describe_pql/describe_pql_query.graphql
Show resolved
Hide resolved
glasser
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than these small comments (one of which needs to be addressed) this is looking great! Looking forward to seeing this in a real Rover release.
glasser
reviewed
Jun 2, 2023
Co-authored-by: David Glasser <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the following commands to be run:
At any time, if you know the graph id and list uuid
rover persisted-queries publish --graph-id <GRAPH_ID> --list-id <LIST_ID> --manifest ./pqm.json
OR if you have linked a persisted query list to a variant, you can do this shorthand:
rover persisted-queries publish <GRAPH_REF> --manifest ./pqm.json
note:
pq
is an alias forpersisted-queries
, you can runrover pq publish
if you would prefer a shorter name.Progress