Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rover persisted-queries publish #1599

Merged
merged 22 commits into from
Jun 8, 2023

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented May 16, 2023

⚠️ not usable in production without internal access


Allows the following commands to be run:

At any time, if you know the graph id and list uuid

rover persisted-queries publish --graph-id <GRAPH_ID> --list-id <LIST_ID> --manifest ./pqm.json

OR if you have linked a persisted query list to a variant, you can do this shorthand:

rover persisted-queries publish <GRAPH_REF> --manifest ./pqm.json

note:pq is an alias for persisted-queries, you can run rover pq publish if you would prefer a shorter name.

Progress

  • Scaffold command
  • Implement GraphQL mutation execution
  • Good error handling
  • Write tests
    • JSON output tests

@EverlastingBugstopper EverlastingBugstopper marked this pull request as draft May 16, 2023 16:23
@EverlastingBugstopper EverlastingBugstopper self-assigned this May 16, 2023
@EverlastingBugstopper EverlastingBugstopper added feature 🎉 new commands, flags, functionality, and improved error messages blocked ⚠️ labels May 16, 2023
@EverlastingBugstopper EverlastingBugstopper changed the title feat: persisted queries feat: rover persisted-queries publish May 16, 2023
@EverlastingBugstopper EverlastingBugstopper added this to the vNext milestone May 30, 2023
@EverlastingBugstopper EverlastingBugstopper marked this pull request as ready for review May 30, 2023 22:37
crates/rover-client/src/error.rs Outdated Show resolved Hide resolved
crates/rover-client/src/error.rs Outdated Show resolved Hide resolved
src/command/output.rs Outdated Show resolved Hide resolved
src/command/persisted_queries/publish.rs Show resolved Hide resolved
src/command/persisted_queries/publish.rs Outdated Show resolved Hide resolved
src/error/metadata/suggestion.rs Outdated Show resolved Hide resolved
@EverlastingBugstopper EverlastingBugstopper modified the milestones: v0.14.2, vNext May 31, 2023
Copy link
Member

@glasser glasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than these small comments (one of which needs to be addressed) this is looking great! Looking forward to seeing this in a real Rover release.

src/error/metadata/suggestion.rs Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
src/command/persisted_queries/mod.rs Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
@EverlastingBugstopper EverlastingBugstopper enabled auto-merge (squash) June 8, 2023 17:24
@EverlastingBugstopper EverlastingBugstopper merged commit f6166d5 into main Jun 8, 2023
@EverlastingBugstopper EverlastingBugstopper deleted the avery/persisted-queries branch June 8, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants