feat: warn when version isn't pinned #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
added
the
feature 🎉
StephenBarlow
approved these changes
Feb 21, 2023
Co-authored-by: Stephen Barlow <[email protected]>
Co-authored-by: Stephen Barlow <[email protected]>
Co-authored-by: Stephen Barlow <[email protected]>
Co-authored-by: Stephen Barlow <[email protected]>
Co-authored-by: Stephen Barlow <[email protected]>
|
Perfect. Thanks for the review @StephenBarlow |
|
@EverlastingBugstopper , is it possible to be any stricter since this is a new version of
|
|
@zionts that'd technically be a breaking change so I'm hesitant to do that. If we wanted to be stricter, we could just hard error, but I think a warning here gives folks a chance to migrate without breaking the world. |
EverlastingBugstopper
added a commit
that referenced
this pull request
Feb 23, 2023
# [0.12.2] - 2023-02-23 ## 🚀 Features - **Warn when `federation_version` is not pinned - @EverlastingBugstopper, #1524** As of this release, we no longer recommend auto-updates for the `rover supergraph compose` command because of the coordination path that is required to roll out new versions of Federation. If you do not specify an exact `federation_version`, a warning will be printed. In a future version of Rover we will entirely deprecate auto-updating, so please migrate now. This change includes some changes to our documentation as well, check out [the docs](https://www.apollographql.com/docs/rover/commands/supergraphs/#setting-a-composition-version) for more information. ## 🐛 Fixes - **Fixes composition error reporting in `rover subgraph check` - @EverlastingBugstopper, #1525** In Rover v0.12.0 and v0.12.1, running a `rover subgraph check` with an invalid schema failed to report the composition errors, this behavior is fixed in v0.12.2. ## 🛠 Maintenance - **Updates internal node dependencies - @EverlastingBugstoppe** `node` v18.14.0 -> v18.14.1 `npm` v9.4.2 -> v9.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
rover supergraph composewithout specifying an exact versionrover supergraph composedocs to point to the router federation version support table, and recommends specifying an exact version instead of the default flow. it also removes the suggestion to submit a bug if there is a breaking change to federation and communicates the importance of updating the router before updating composition.To be clear: I do not think that this is a solution to unexpected breaking changes being delivered between point releases. This is however a solution to the current situation where those breaking changes are delivered automatically on the behalf of composers, quite likely breaking their routers, which we do not automatically update for them.
The breaking changes between point releases is a larger discussion that we are having internally, but it will take quite some time to resolve. This is an interim solution to the immediate problems described in #1510 and is intended to give composers much more control over how updates are delivered and rolled out.