Merge branch 'main' into camille/update-format-option #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be merged after apollographql/docs#254 is merged
in CI - the router only caches `~/.cargo` and not `/target`, because `/target` makes the cache much too big, resulting in large download/upload times. caching only `~/.cargo` is likely the best path forward here.
Co-authored-by: Avery Harnish <[email protected]>
Co-authored-by: Avery Harnish <[email protected]> Co-authored-by: Avery Harnish <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
updates `rust-toolchain.toml` and addresses the new clippy lints that came with the new release.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
previously, we had been re-exporting common functionality in the saucer crate which lived in a personal repository of mine. this lead to not great readability and upgrading dependencies/usage patterns became unsustainable. this PR reverts those changes and starts using those crates directly, in addition to creating a new `rover_std` workspace crate for reusable functionality related to command input/output
EverlastingBugstopper
requested review from
StephenBarlow and
lrlna
as code owners
This PR updates to clap v4.
gocamille
approved these changes
Nov 10, 2022
gocamille
pushed a commit
that referenced
this pull request
Nov 24, 2022
Co-authored-by: Trevor Blades <[email protected]> Co-authored-by: Sachin D. Shinde <[email protected]> Co-authored-by: Jesse Wang <[email protected]> Co-authored-by: Patrick Arminio <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
gocamille
pushed a commit
that referenced
this pull request
Nov 30, 2022
Co-authored-by: Trevor Blades <[email protected]> Co-authored-by: Sachin D. Shinde <[email protected]> Co-authored-by: Jesse Wang <[email protected]> Co-authored-by: Patrick Arminio <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
gocamille
pushed a commit
that referenced
this pull request
Jan 9, 2023
Co-authored-by: Trevor Blades <[email protected]> Co-authored-by: Sachin D. Shinde <[email protected]> Co-authored-by: Jesse Wang <[email protected]> Co-authored-by: Patrick Arminio <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1402 made for some weird merge conflicts, figured i'd push up a merge since i've got the context on what needs updating.