-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds rover install --plugin supergraph-{0,2} #1058
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-cli-docs canceled.
|
EverlastingBugstopper
force-pushed
the
avery/auto-download
branch
from
March 31, 2022 21:34
29b3a54
to
e82c66e
Compare
EverlastingBugstopper
force-pushed
the
avery/auto-download
branch
from
April 4, 2022 16:55
30884a6
to
9c6ffe7
Compare
EverlastingBugstopper
force-pushed
the
avery/auto-download
branch
from
April 4, 2022 21:38
9e92b2d
to
5c8b095
Compare
EverlastingBugstopper
force-pushed
the
avery/auto-download
branch
from
April 4, 2022 21:40
5c8b095
to
6886c15
Compare
This was referenced Apr 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1046.
this PR adds
rover install --plugin supergraph-{0,2}
and removesrover-fed2
.the curl and npm installers will both run
rover install --plugin supergraph@latest-0
androver install --plugin supergraph@latest-2
. you can runrover install --plugin [email protected]
to get an exact version.rover supergraph compose
will check if a new supergraph binary has been released and download that to use it for composition if it is available. these network checks can be skipped with--skip-update
in order to use the plugins that were installed at the same time as rover. you can also specifyfederation_version: =2.0.0
insupergraph.yaml
to get an exact version that will only download the plugin once and won't check for updates unless the number changes.the npm installer now puts rover in
~/node_modules/.bin
instead of~/node_modules/binary-install/bin
, and setsAPOLLO_NODE_MODULES_BIN_DIR
so that rover knows where it lives and can install the supergraph binaries there as well.