Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds rover install --plugin supergraph-{0,2} #1058

Merged
merged 18 commits into from
Apr 5, 2022

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Mar 31, 2022

fixes #1046.

this PR adds rover install --plugin supergraph-{0,2} and removes rover-fed2.

the curl and npm installers will both run rover install --plugin supergraph@latest-0 and rover install --plugin supergraph@latest-2. you can run rover install --plugin [email protected] to get an exact version.

rover supergraph compose will check if a new supergraph binary has been released and download that to use it for composition if it is available. these network checks can be skipped with --skip-update in order to use the plugins that were installed at the same time as rover. you can also specify federation_version: =2.0.0 in supergraph.yaml to get an exact version that will only download the plugin once and won't check for updates unless the number changes.

the npm installer now puts rover in ~/node_modules/.bin instead of ~/node_modules/binary-install/bin, and sets APOLLO_NODE_MODULES_BIN_DIR so that rover knows where it lives and can install the supergraph binaries there as well.

@netlify
Copy link

netlify bot commented Mar 31, 2022

Deploy Preview for apollo-cli-docs canceled.

Name Link
🔨 Latest commit f1d41f5
🔍 Latest deploy log https://app.netlify.com/sites/apollo-cli-docs/deploys/624c9212e5336e000a04c17e

@EverlastingBugstopper EverlastingBugstopper added this to the 0.5.0 milestone Apr 4, 2022
@EverlastingBugstopper EverlastingBugstopper merged commit 3e4781d into main Apr 5, 2022
@EverlastingBugstopper EverlastingBugstopper deleted the avery/auto-download branch April 5, 2022 19:03
This was referenced Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto-download the correct version of supergraph plugin when running rover supergraph compose
1 participant