Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumps harmonizer versions #1025

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Mar 7, 2022

waiting until new fed2 preview packages are dropped to merge this.

@EverlastingBugstopper
Copy link
Contributor Author

EverlastingBugstopper commented Mar 7, 2022

i'm... honestly not sure why supergraph-demo tests are failing here. i'm able to run rover supergraph compose --config supergraph-demo/supergraph.yaml with what's on supergraph-demo/main just fine. unfortunately the only error messages i can find are these:

$ cargo xtask integration-test
..
..
long output...
..
..
docker-compose up -d
Starting Apollo Gateway in local mode ...
Using local: /etc/config/supergraph.graphql
Running smoke tests ... 🚀 🚀 🚀

==============================================================
TEST 1: allProducts with delivery
==============================================================

Error: Encountered an issue while executing `make ci`

Caused by:
    Exited with status code 2

@EverlastingBugstopper
Copy link
Contributor Author

EverlastingBugstopper commented Mar 8, 2022

it looks like when we updateed deno_core, it started spitting out cargo:rerun-if-changed messages during the runtime initialization. here is an issue describing the problem: denoland/deno#11030

we will need to release patched versions of pretty much everything in federation-rs I think, and it seems like the only solution is to use snapshots like router-bridge does. or we could have the library try to swallow stdout until the runtime is initialized? either way we'll need to yank some versions or publish patches.

@EverlastingBugstopper EverlastingBugstopper merged commit e6fdc74 into main Mar 9, 2022
@EverlastingBugstopper EverlastingBugstopper deleted the avery/update-harmonizer branch March 9, 2022 21:47
@EverlastingBugstopper
Copy link
Contributor Author

the fed 2 version was then subsequently bumped to 2.0.0-preview.2 before being released in #1029

@EverlastingBugstopper EverlastingBugstopper added this to the 0.4.4 or 0.5.0 milestone Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant