Merged
Conversation
Adds h2 as an explicit workspace dependency with a minimum version of 0.4.13 to ensure the router picks up the latest patch release. Without an explicit declaration, h2 is only a transitive dependency and Renovate will not manage it, leaving the version pinned in Cargo.lock indefinitely unless someone manually runs cargo update. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds h2.workspace = true to apollo-router/Cargo.toml so the minimum version floor declared in [workspace.dependencies] is actually enforced by the cargo resolver, and Renovate can manage future bumps via the workspace entry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaces the previous Cargo.lock update (which contained 7 unintended resolver re-selections of socket2 and windows-sys versions) with a targeted cargo update -p h2 --precise 0.4.13. Only h2 and its entry in the apollo-router dependency list change. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…deps The [workspace.dependencies] table is for deps used in more than one workspace member. h2 is a transitive-only dep being pinned, so it belongs directly in apollo-router/Cargo.toml following the same pattern as the existing socket2 declaration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…aroline/router-1659-h2-update
Contributor
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 91738fd4bd5e35fa4569b7f0 ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
2 tasks
aaronArinder
approved these changes
Mar 20, 2026
theJC
reviewed
Mar 20, 2026
| @@ -0,0 +1,11 @@ | |||
| ### Pin transitive `h2` dependency at minimum v0.4.13 to pick up critical flow-control, deadlock, and tracing fixes ([PR #9033](https://github.com/apollographql/router/pull/9033)) | |||
|
|
|||
| `h2` 0.4.13 (released January 5, 2026) contains three fixes directly relevant to the router, which uses h2 exclusively as a client when connecting to subgraphs: | |||
Contributor
There was a problem hiding this comment.
I missed correcting this in my original PR... h2 is often used, but not exclusively used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hidden dependency of hyper and tonic. There are a few changes in the latest release that we want to adopt (see the changeset).
Closes #9033.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩