Conversation
!paths.is_empty is checked above as a condition for this block
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: 748f7ff34a0bce521d758871 URL: https://www.apollographql.com/docs/deploy-preview/748f7ff34a0bce521d758871
|
This comment has been minimized.
This comment has been minimized.
Applied suggestions from AI review 20260317-911566dd-9022-fc0e624187928c55: - docs/source/routing/security/authorization.mdx:384: Do not use articles before standalone product names like Router.; Do not use ita... - docs/source/routing/security/authorization.mdx:923: Use the reader-centric 'you' instead of passive voice to make the instruction mo... Review: #9022 Triggered by: caroline.rodewig@apollographql.com
When the query planner rejects a request because all fields are unauthorized, the response was always returned with errors in the
errorsarray anddata: {}— ignoring the configurederrors.responselocation and returning an empty object instead ofnull.This fix makes fully-unauthorized requests go through the same error formatting path as partially-unauthorized ones, so the
errors.responseanderrors.logconfiguration is respected consistently. It also corrects the response to returndata: nullinstead ofdata: {}.The shared logic is consolidated into methods on
UnauthorizedPaths, replacing duplicated inline implementations in bothexecution/service.rsandquery_planner_service.rs.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩