Skip to content

fix: don't enable HTTP/1 when the http2only config option is used#9018

Merged
carodewig merged 8 commits intodevfrom
caroline/rh-1314
Mar 16, 2026
Merged

fix: don't enable HTTP/1 when the http2only config option is used#9018
carodewig merged 8 commits intodevfrom
caroline/rh-1314

Conversation

@carodewig
Copy link
Copy Markdown
Contributor

@carodewig carodewig commented Mar 13, 2026

The hyper client does not implement h2c upgrades. In order to use HTTP/2 without TLS/ALPN, you must use 'prior knowledge' (aka specify experimental_http2: http2only).

Prior to this change, that 'prior knowledge' piece wouldn't work - the client would support both http1 and http2. This fix ensures it will only use http2 if so configured.

experimental_http2 client config TLS enabled behavior
disable true http/1
disable false http/1
enable true http/2 (if server accepts it), else http/1
enable false http/1
http2only true http/2
http2only false http/2

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@carodewig carodewig requested a review from a team as a code owner March 13, 2026 13:44
@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Mar 13, 2026

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: ebf7ce8350a6336d673ed777
Build Logs: View logs


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@github-actions

This comment has been minimized.

@aaronArinder aaronArinder self-assigned this Mar 13, 2026
@carodewig carodewig merged commit 6e23ed3 into dev Mar 16, 2026
15 checks passed
@carodewig carodewig deleted the caroline/rh-1314 branch March 16, 2026 19:37
@abernix abernix mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants