Skip to content

feat(http clients): pool idle timeout#9014

Merged
aaronArinder merged 2 commits intodevfrom
aaron/make-http-idle-pool-timeout-configurable
Mar 13, 2026
Merged

feat(http clients): pool idle timeout#9014
aaronArinder merged 2 commits intodevfrom
aaron/make-http-idle-pool-timeout-configurable

Conversation

@aaronArinder
Copy link
Copy Markdown
Contributor

@aaronArinder aaronArinder commented Mar 12, 2026


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@aaronArinder aaronArinder requested a review from a team as a code owner March 12, 2026 19:18
@github-actions

This comment has been minimized.

@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Mar 12, 2026

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 3 changed, 0 removed
* graphos/routing/(latest)/errors.mdx
* graphos/routing/(latest)/configuration/yaml.mdx
* graphos/routing/(latest)/performance/traffic-shaping.mdx

Build ID: 910ec0d93d1df28b12b6985a
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/910ec0d93d1df28b12b6985a


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@aaronArinder
Copy link
Copy Markdown
Contributor Author

cc @theJC

@aaronArinder aaronArinder force-pushed the aaron/make-http-idle-pool-timeout-configurable branch 2 times, most recently from 5b76c8b to 9957e01 Compare March 12, 2026 19:55
Copy link
Copy Markdown
Contributor

@carodewig carodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think you need to update the snapshots again but otherwise good to go.

Just want to say that I love the pool_idle_timeout tests 🙌

@aaronArinder aaronArinder force-pushed the aaron/make-http-idle-pool-timeout-configurable branch from 9957e01 to d6859d7 Compare March 12, 2026 20:59
@aaronArinder aaronArinder enabled auto-merge (squash) March 12, 2026 20:59
@aaronArinder aaronArinder merged commit 667ea73 into dev Mar 13, 2026
15 checks passed
@aaronArinder aaronArinder deleted the aaron/make-http-idle-pool-timeout-configurable branch March 13, 2026 14:13
smyrick pushed a commit that referenced this pull request Mar 17, 2026
smyrick pushed a commit that referenced this pull request Mar 20, 2026
@abernix abernix mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants