Skip to content

fix: return 503 for rate limit traffic shaping#9013

Merged
carodewig merged 7 commits intodevfrom
caroline/revert-8765
Mar 12, 2026
Merged

fix: return 503 for rate limit traffic shaping#9013
carodewig merged 7 commits intodevfrom
caroline/revert-8765

Conversation

@carodewig
Copy link
Copy Markdown
Contributor

@carodewig carodewig commented Mar 12, 2026

Reverts #8765.

The 429 error code indicates that a single client has sent too many requests, not that the entire service has received too many requests. This PR replaces the 429 with a 503.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@carodewig carodewig requested a review from a team as a code owner March 12, 2026 15:07
@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Mar 12, 2026

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 2 changed, 0 removed
* graphos/routing/(latest)/errors.mdx
* graphos/routing/(latest)/performance/traffic-shaping.mdx

Build ID: a75b70f1109cd86cc7a71f06
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/a75b70f1109cd86cc7a71f06


⚠️ AI Style Review — 3 Issues Found

Summary

This pull request updates the documentation to align with several style guide sections. In 'word-and-symbol-usage', numbers in technical contexts now use numerals with code font, and 'client-side' is correctly hyphenated as a compound modifier. Under 'language' and 'voice', hyphenation was standardized and passive phrasing was replaced with authoritative 'Use' statements. For 'text-formatting', vague link text like 'See' was replaced with descriptive noun/verb phrases with links at the end of sentences, and HTTP status codes now use code font. Finally, in 'products-and-features', articles were removed before standalone product names like Apollo Router.

Duration: 3165ms
Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@github-actions

This comment has been minimized.

@carodewig carodewig enabled auto-merge (squash) March 12, 2026 15:11
carodewig and others added 2 commits March 12, 2026 11:11
Applied suggestions from AI review 20260312-911566dd-9013-25452252edc153f9:
- docs/source/routing/performance/traffic-shaping.mdx:58: Do not use an article before a standalone product name like Apollo Router.; Use ...
- docs/source/routing/errors.mdx:58: Use reader-centric language like "your" to clarify ownership of the configuratio...

Review: #9013
Triggered by: caroline.rodewig@apollographql.com
@aaronArinder aaronArinder self-assigned this Mar 12, 2026
@carodewig carodewig merged commit b9f2a9e into dev Mar 12, 2026
15 checks passed
@carodewig carodewig deleted the caroline/revert-8765 branch March 12, 2026 15:52
@abernix abernix mentioned this pull request Mar 31, 2026
@goto-bus-stop goto-bus-stop mentioned this pull request Apr 1, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants