chore: reintroduce test_redis_storage_with_mocks test#9010
Merged
BrynCooke merged 3 commits intobryn/otel-0.31-migrationfrom Mar 11, 2026
Merged
Conversation
struggling to get this to pass at the moment 🙈
Contributor
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 2 changed, 0 removedBuild ID: 001de9f1e38bae796308dbfe URL: https://www.apollographql.com/docs/deploy-preview/001de9f1e38bae796308dbfe ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
goto-bus-stop
commented
Mar 11, 2026
| pub(crate) struct RedisMetricsCollector { | ||
| /// None until activate() is called | ||
| /// TODO(@goto-bus-stop): actually this should maybe be a Once? | ||
| abort_handle: parking_lot::Mutex<Option<AbortHandle>>, |
Member
Author
There was a problem hiding this comment.
our Mutex<Option> looks a lot like a https://doc.rust-lang.org/stable/std/sync/struct.OnceLock.html
goto-bus-stop
commented
Mar 11, 2026
| let storage = RedisCacheStorage::from_mocks(simple_map.clone()) | ||
| .await | ||
| .expect("Failed to create Redis storage with mocks"); | ||
| storage.activate(); |
Member
Author
There was a problem hiding this comment.
I did add the .activate() call
Use with_current_meter_provider to allow propagation of meter provider to the tokio thread spawned in activate. Metrics tests need this.
BrynCooke
deleted the
renee/otel-0.31-reintroduce-test_redis_storage_with_mocks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
struggling to get this to pass at the moment 🙈
@BrynCooke can you help me pleasepleaseplease 🥺
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩