Skip to content

DIY Dockerfile.repo not honoring cargo locks results in non-deterministic builds #8983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theJC wants to merge 3 commits into from
Closed

DIY Dockerfile.repo not honoring cargo locks results in non-deterministic builds #8983

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31d5742
DIY Dockerfile.repo missing --locked on cargo install, resulting in u…
theJC Mar 7, 2026
1d84fe7
Change to cargo build --release that honors lockfile, to more closely…
theJC Mar 7, 2026
9cfc321
Merge branch 'dev' into fix/DockerfileNeedsToBeLocked
abernix Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dockerfiles/diy/dockerfiles/Dockerfile.repo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ RUN rustup component add rustfmt
# Copy the router source to our build environment
COPY . .

# Build and install the router
RUN cargo install --path apollo-router
Copy link
Copy Markdown
Contributor Author

@theJC theJC Mar 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because this didnt have --locked it was not honoring the cargo lock, and builds of an identical hash could end up with a different version of libraries.

# Build the router
RUN cargo build --release -p apollo-router
Copy link
Copy Markdown
Contributor Author

@theJC theJC Mar 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what the ci build uses, lets use this which honors the lockfile and so the DIY more closely aligns to the ci build.


# Make directories for config and schema
RUN mkdir -p /dist/config && \
mkdir /dist/schema && \
mv /usr/local/cargo/bin/router /dist
mv target/release/router /dist
Copy link
Copy Markdown
Contributor Author

@theJC theJC Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are building and not installing now


# Copy configuration for docker image
COPY dockerfiles/router.yaml /dist/config
Expand Down
Loading