Skip to content

fix(response_at_path): non-greedy application of errors when current_dir wildcarded (backport #8962)#8979

Merged
aaronArinder merged 1 commit intodev-v2.10.xfrom
mergify/bp/dev-v2.10.x/pr-8962
Mar 6, 2026
Merged

fix(response_at_path): non-greedy application of errors when current_dir wildcarded (backport #8962)#8979
aaronArinder merged 1 commit intodev-v2.10.xfrom
mergify/bp/dev-v2.10.x/pr-8962

Conversation

@aaronArinder
Copy link
Copy Markdown
Contributor


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

[ROUTER-1653]: https://apollographql.atlassian.net/browse/ROUTER-1653?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ


This is an automatic backport of pull request #8962 done by Mergify.

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@aaronArinder aaronArinder requested a review from a team as a code owner March 6, 2026 15:48
@mergify mergify bot added the conflicts label Mar 6, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 6, 2026

Cherry-pick of 04d42e2 has failed:

On branch mergify/bp/dev-v2.10.x/pr-8962
Your branch is up to date with 'origin/dev-v2.10.x'.

You are currently cherry-picking commit 04d42e2e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .changesets/fix_aaron_non_greedy_path_application_for_errors.md
	modified:   apollo-router/src/query_planner/fetch.rs
	modified:   apollo-router/src/services/execution/service.rs
	modified:   apollo-router/src/services/supergraph/snapshots/apollo_router__services__supergraph__tests__deferred_fragment_bounds_nullability-2.snap
	modified:   apollo-router/tests/integration/query_planner/snapshots/integration_tests__integration__query_planner__error_paths__multi_level_response_failure.snap
	modified:   apollo-router/tests/integration/query_planner/snapshots/integration_tests__integration__query_planner__error_paths__nested_response_failure_404.snap
	modified:   apollo-router/tests/integration/query_planner/snapshots/integration_tests__integration__query_planner__error_paths__nested_response_failure_malformed.snap
	modified:   apollo-router/tests/integration/query_planner/snapshots/integration_tests__integration__query_planner__error_paths__second_level_response_failure_empty_path.snap
	modified:   apollo-router/tests/integration/query_planner/snapshots/integration_tests__integration__query_planner__error_paths__second_level_response_failure_malformed.snap
	modified:   apollo-router/tests/integration/snapshots/integration_tests__integration__coprocessor__on_graphql_error_selector__nested_response_failure.snap

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   apollo-router/tests/integration/snapshots/integration_tests__integration__demand_control__requests_exceeding_one_subgraph_cost_are_accepted@federated_ships_required.snap

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Mar 6, 2026

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

1 new, 55 changed, 5 removed
+ graphos/routing/(latest)/customization/coprocessor.mdx
* graphos/routing/(latest)/about-v2.mdx
* graphos/routing/(latest)/errors.mdx
* graphos/routing/(latest)/license.mdx
* graphos/routing/(latest)/uplink.mdx
* graphos/routing/(latest)/cloud/aws-migration.mdx
* graphos/routing/(latest)/cloud/configuration.mdx
* graphos/routing/(latest)/cloud/custom-domains.mdx
* graphos/routing/(latest)/cloud/dedicated-quickstart.mdx
* graphos/routing/(latest)/cloud/dedicated.mdx
* graphos/routing/(latest)/cloud/index.mdx
* graphos/routing/(latest)/cloud/lattice-configuration.mdx
* graphos/routing/(latest)/cloud/lattice-management.mdx
* graphos/routing/(latest)/cloud/lattice-troubleshooting.mdx
* graphos/routing/(latest)/cloud/migrate-to-dedicated.mdx
* graphos/routing/(latest)/cloud/secure-subgraphs.mdx
* graphos/routing/(latest)/cloud/serverless.mdx
* graphos/routing/(latest)/cloud/subscriptions.mdx
* graphos/routing/(latest)/cloud/throughput-guide.mdx
* graphos/routing/(latest)/configuration/cli.mdx
* graphos/routing/(latest)/configuration/envvars.mdx
* graphos/routing/(latest)/configuration/overview.mdx
* graphos/routing/(latest)/configuration/yaml.mdx
* graphos/routing/(latest)/customization/native-plugins.mdx
* graphos/routing/(latest)/customization/coprocessor/index.mdx
* graphos/routing/(latest)/customization/coprocessor/reference.mdx
* graphos/routing/(latest)/customization/rhai/reference.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/apm-guides/datadog/router-instrumentation.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/selectors.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/spans.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/standard-instruments.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/telemetry-pipelines/metrics-exporters/overview.mdx
* graphos/routing/(latest)/operations/subscriptions/api-gateway.mdx
* graphos/routing/(latest)/operations/subscriptions/configuration.mdx
* graphos/routing/(latest)/operations/subscriptions/overview.mdx
* graphos/routing/(latest)/performance/traffic-shaping.mdx
* graphos/routing/(latest)/performance/caching/response-caching/faq.mdx
* graphos/routing/(latest)/performance/caching/response-caching/invalidation.mdx
* graphos/routing/(latest)/performance/caching/response-caching/observability.mdx
* graphos/routing/(latest)/performance/caching/response-caching/quickstart.mdx
* graphos/routing/(latest)/query-planning/caching.mdx
* graphos/routing/(latest)/security/demand-control.mdx
* graphos/routing/(latest)/security/index.mdx
* graphos/routing/(latest)/security/jwt.mdx
* graphos/routing/(latest)/security/persisted-queries.mdx
* graphos/routing/(latest)/security/router-authentication.mdx
* graphos/routing/(latest)/self-hosted/index.mdx
* graphos/routing/(latest)/self-hosted/containerization/aws.mdx
* graphos/routing/(latest)/self-hosted/containerization/azure.mdx
* graphos/routing/(latest)/self-hosted/containerization/docker-router-only.mdx
* graphos/routing/(latest)/self-hosted/containerization/docker.mdx
* graphos/routing/(latest)/self-hosted/containerization/gcp.mdx
* graphos/routing/(latest)/self-hosted/containerization/index.mdx
* graphos/routing/(latest)/self-hosted/containerization/kubernetes/quickstart.mdx
* graphos/routing/(latest)/upgrade/from-router-v1.mdx
* graphos/routing/(latest)/_sidebar.yaml
- graphos/routing/(latest)/cloud/migrate-to-self-hosted.mdx
- graphos/routing/(latest)/configuration/hot-reload-schema.mdx
- graphos/routing/(latest)/configuration/schema-file.mdx
- graphos/routing/(latest)/performance/circuit-breaking.mdx
- graphos/routing/(latest)/self-hosted/containerization/proxy-certificates.mdx

Build ID: 2aa64c5539010a5ae48ed617
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/2aa64c5539010a5ae48ed617


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@abernix
Copy link
Copy Markdown
Member

abernix commented Mar 6, 2026

Stay tuned, I have a PR that will fix CI.

…dir wildcarded (#8962)

(cherry picked from commit 04d42e2)

# Conflicts:
#	apollo-router/tests/integration/snapshots/integration_tests__integration__demand_control__requests_exceeding_one_subgraph_cost_are_accepted@federated_ships_required.snap
@aaronArinder aaronArinder force-pushed the mergify/bp/dev-v2.10.x/pr-8962 branch from 2346dd2 to 590aed3 Compare March 6, 2026 19:57
@aaronArinder aaronArinder merged commit 39320a5 into dev-v2.10.x Mar 6, 2026
14 checks passed
@aaronArinder aaronArinder deleted the mergify/bp/dev-v2.10.x/pr-8962 branch March 6, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants