Skip to content

docs: document http_client span attribute limitations#8967

Merged
mabuyo merged 8 commits intodevfrom
docs/DXM-553
Mar 10, 2026
Merged

docs: document http_client span attribute limitations#8967
mabuyo merged 8 commits intodevfrom
docs/DXM-553

Conversation

@mabuyo
Copy link
Copy Markdown
Contributor

@mabuyo mabuyo commented Mar 4, 2026

Summary

Document that http_client span attributes do not support conditions or the static selector, causing a router startup failure when attempted.

Changes

  • [2] docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/spans.mdx — Extend the conditions paragraph to explicitly carve out http_client, noting that conditions and static are not supported for that service.
  • [1] docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/spans.mdx — Add a <Note> callout in the http_client span attributes section with the startup error message users encounter.
  • [3] docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/selectors.mdx — Add a <Note> under the HTTP Client selector section stating that conditions and the static selector are not supported.

Commits

  • ac9734f docs: note conditions/static not supported for http_client spans
  • 0dda783 docs: add note on http_client attribute limitations with error message
  • 115ecd9 docs: document http_client selector limitations and add conditions column

🤖 Generated with Claude Code (docs-scribe)

@mabuyo mabuyo requested a review from a team as a code owner March 4, 2026 23:14
@github-actions

This comment has been minimized.

@mabuyo mabuyo marked this pull request as draft March 4, 2026 23:15
@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Mar 6, 2026

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 2 changed, 0 removed
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/selectors.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/spans.mdx

Build ID: 50b1dfce268956f817e87b9e
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/50b1dfce268956f817e87b9e


⚠️ AI Style Review — 5 Issues Found

Summary

This pull request updates the documentation to align with several style guide requirements. Structural changes include ensuring proper spacing around tags and admonition components for correct rendering. Text formatting improvements involve replacing vague link text with descriptive titles and removing non-standard bold emphasis. Framing and products-and-features updates remove personal possessives like "your" in favor of a neutral or imperative tone. Voice adjustments replace robotic or passive phrasing with authoritative, reader-centric guidance. Finally, word and symbol usage was refined to include natural contractions and clear directional references.

Duration: 2990ms
Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

Applied suggestions from AI review 20260306-911566dd-8967-1391116fc81a9852:
- docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/selectors.mdx:118: Frame the failure relative to the reader's router to be more reader-centric.; Re...
- docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/spans.mdx:74: Do not use bold for general emphasis. Avoid using 'here' or vague phrases as lin...
- docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/spans.mdx:277: Focus on what is supported rather than what is not supported to maintain a posit...

Review: #8967
Triggered by: michelle@apollographql.com
@mabuyo mabuyo marked this pull request as ready for review March 6, 2026 21:36
@mabuyo mabuyo requested a review from a team March 6, 2026 21:52
@mabuyo
Copy link
Copy Markdown
Contributor Author

mabuyo commented Mar 6, 2026

I filled in the CLA with my information but it's still showing failure. Is this because Claude is listed as an author in the commits? I was testing out a Claude workflow for tackling docs.

@mabuyo mabuyo changed the title docs(DXM-553): document http_client span attribute limitations docs: document http_client span attribute limitations Mar 9, 2026
apollo-librarian bot and others added 2 commits March 10, 2026 15:19
Applied suggestions from AI review 20260309-911566dd-8967-7480c713df830965:
- docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/selectors.mdx:118: Focus on what is supported rather than emphasizing the disadvantages or limitati...
- docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/spans.mdx:74: Avoid using code font for link text; use a rich noun phrase instead.; Use dictio...
- docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/spans.mdx:277: Use reader-centric framing ('If you attempt') and active voice ('the router fail...

Review: #8967
Triggered by: michelle@apollographql.com
@mabuyo mabuyo merged commit 88d17ed into dev Mar 10, 2026
15 checks passed
@mabuyo mabuyo deleted the docs/DXM-553 branch March 10, 2026 17:43
smyrick pushed a commit that referenced this pull request Mar 17, 2026
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: apollo-librarian[bot] <212934294+apollo-librarian[bot]@users.noreply.github.com>
smyrick pushed a commit that referenced this pull request Mar 20, 2026
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: apollo-librarian[bot] <212934294+apollo-librarian[bot]@users.noreply.github.com>
@abernix abernix mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants