docs: document http_client span attribute limitations#8967
Conversation
This comment has been minimized.
This comment has been minimized.
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 2 changed, 0 removedBuild ID: 50b1dfce268956f817e87b9e URL: https://www.apollographql.com/docs/deploy-preview/50b1dfce268956f817e87b9e
|
Applied suggestions from AI review 20260306-911566dd-8967-1391116fc81a9852: - docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/selectors.mdx:118: Frame the failure relative to the reader's router to be more reader-centric.; Re... - docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/spans.mdx:74: Do not use bold for general emphasis. Avoid using 'here' or vague phrases as lin... - docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/spans.mdx:277: Focus on what is supported rather than what is not supported to maintain a posit... Review: #8967 Triggered by: michelle@apollographql.com
|
I filled in the CLA with my information but it's still showing failure. Is this because Claude is listed as an author in the commits? I was testing out a Claude workflow for tackling docs. |
Applied suggestions from AI review 20260309-911566dd-8967-7480c713df830965:
- docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/selectors.mdx:118: Focus on what is supported rather than emphasizing the disadvantages or limitati...
- docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/spans.mdx:74: Avoid using code font for link text; use a rich noun phrase instead.; Use dictio...
- docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/spans.mdx:277: Use reader-centric framing ('If you attempt') and active voice ('the router fail...
Review: #8967
Triggered by: michelle@apollographql.com
Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: apollo-librarian[bot] <212934294+apollo-librarian[bot]@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: apollo-librarian[bot] <212934294+apollo-librarian[bot]@users.noreply.github.com>
Summary
Document that
http_clientspan attributes do not support conditions or thestaticselector, causing a router startup failure when attempted.Changes
docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/spans.mdx— Extend the conditions paragraph to explicitly carve outhttp_client, noting that conditions andstaticare not supported for that service.docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/spans.mdx— Add a<Note>callout in thehttp_clientspan attributes section with the startup error message users encounter.docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/selectors.mdx— Add a<Note>under the HTTP Client selector section stating that conditions and thestaticselector are not supported.Commits
🤖 Generated with Claude Code (docs-scribe)