feat: add persisted query ID context key and update related functiona…#8959
feat: add persisted query ID context key and update related functiona…#8959faisalwaseem merged 14 commits intodevfrom
Conversation
…lity as requested by in https://apollographql.atlassian.net/browse/TSH-22140 - Introduced a new context key for persisted query ID in the Apollo Router. - Updated the PersistedQueryLayer to store the persisted query ID in the request context. - Enhanced the Rhai engine to utilize the new persisted query ID context key. - Added tests to verify the correct storage and retrieval of the persisted query ID from the context. - Updated documentation to reflect the new context key for persisted queries.
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 3 changed, 0 removedBuild ID: f12ccd697fb4273ba4ec7979 URL: https://www.apollographql.com/docs/deploy-preview/f12ccd697fb4273ba4ec7979
|
This comment has been minimized.
This comment has been minimized.
- Updated the context key from `PERSISTED_QUERY_ID` to `PERSISTED_QUERY_ID_KEY` in the Rhai engine and corresponding documentation. - Ensured that all references to the persisted query ID context key are consistent across the codebase and documentation.
- Changed the import of the persisted query ID context key from `PERSISTED_QUERY_ID_KEY` to `PERSISTED_QUERY_ID` for consistency with recent updates.
…gine - Updated the global variable reference for the persisted query ID context key from `PERSISTED_QUERY_ID_KEY` to `PERSISTED_QUERY_ID` to maintain consistency with recent changes.
rohan-b99
left a comment
There was a problem hiding this comment.
This looks good to me, I think we just need a changeset
Co-authored-by: rohan-b99 <43239788+rohan-b99@users.noreply.github.com>
Co-authored-by: rohan-b99 <43239788+rohan-b99@users.noreply.github.com>
Co-authored-by: rohan-b99 <43239788+rohan-b99@users.noreply.github.com>
Co-authored-by: rohan-b99 <43239788+rohan-b99@users.noreply.github.com>
#8959) Co-authored-by: Michelle Mabuyo <michelle@apollographql.com> Co-authored-by: rohan-b99 <43239788+rohan-b99@users.noreply.github.com>
#8959) Co-authored-by: Michelle Mabuyo <michelle@apollographql.com> Co-authored-by: rohan-b99 <43239788+rohan-b99@users.noreply.github.com>
feat: add persisted query ID context key and update related functionality as requested by in https://apollographql.atlassian.net/browse/TSH-22140
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩