fix: correct no-store and no-cache behavior for response cache#8948
Merged
fix: correct no-store and no-cache behavior for response cache#8948
Conversation
Contributor
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: 12e7c00917907d23adc8425d URL: https://www.apollographql.com/docs/deploy-preview/12e7c00917907d23adc8425d ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
This comment has been minimized.
This comment has been minimized.
aaronArinder
approved these changes
Mar 3, 2026
10 tasks
carodewig
added a commit
that referenced
this pull request
Mar 3, 2026
carodewig
added a commit
that referenced
this pull request
Mar 3, 2026
smyrick
pushed a commit
that referenced
this pull request
Mar 4, 2026
smyrick
pushed a commit
that referenced
this pull request
Mar 17, 2026
smyrick
pushed a commit
that referenced
this pull request
Mar 20, 2026
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confusingly,
no-storeandno-cachehave different meanings. Per RFC 9111:no-store: allows serving response from cache, but prohibits storing response in cacheno-cache: prohibits serving response from cache, but allows storing response in cache(NB:
no-cacheactually prohibits serving response from cache without revalidation - but the router doesn't distinguish between lookup and revalidation)The response caching plugin was incorrectly treating
no-storeas both 'no serving response from the cache' and 'no storing response in the cache.'This PR fixes that behavior.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩