Merged
Conversation
(cherry picked from commit f6137d4)
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
carodewig
pushed a commit
that referenced
this pull request
Mar 3, 2026
smyrick
pushed a commit
that referenced
this pull request
Mar 17, 2026
smyrick
pushed a commit
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8864
Summary
bnfto 0.6 and remove therandversion pin that was required until bnf 0.6 (see #7897).connector_selection_parsefuzz target: switch to bnf'sCoverageGuidedstrategy and run multiple generations per fuzz input so we exercise more grammar productions per seed.Motivation
randand uses rand 0.9, so the fuzz crate no longer needs a pinnedranddependency.connector_selection_parsetarget previously used a single grammar generation per input;CoverageGuidedonly helps when the same strategy is reused across generations. Running several generations per input (same seed, same strategy) lets the strategy prefer previously unused productions, improving grammar coverage for the JSON selection parser fuzz run.Changes
fuzz/Cargo.toml: bumpbnffrom0.5.0to0.6, removerand = "=0.8.5"and the comment about bnf PR fix(deps): update rust crate anyhow to 1.0.48 #175.fuzz/fuzz_targets/connector_selection_parse.rs: usebnf::CoverageGuidedandbnf::rand(no directranddep); generate up to 8 selections per fuzz input viagenerate_seeded_with_strategyand parse each; keepCorpus::Rejectwhen no generation succeeds (e.g. non-terminating expansion).Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
cargo check -p router-fuzzand by running theconnector_selection_parsefuzz target.Notes
This is an automatic copy of pull request #8864 done by [Mergify](https://mergify.com).
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩