fix: set no-store cache-control header when response has an error#8933
Merged
fix: set no-store cache-control header when response has an error#8933
Conversation
…ns GraphQL errors When a query spans multiple subgraphs and one of them returns an error or times out, the final HTTP response was still carrying the successful subgraph's Cache-Control header (e.g. max-age=1800, public). This allowed intermediate caches (CDNs, NGINX) to cache and serve incomplete or stale partial responses to other clients. Fix the supergraph_service layer to check the CONTAINS_GRAPHQL_ERROR context key before writing the Cache-Control header. If any GraphQL errors are present in the response, write Cache-Control: no-store instead of the merged subgraph cache control. Add two regression tests: - no_store_on_partial_subgraph_failure: one subgraph returns a GraphQL error while another returns cacheable data - no_store_on_subgraph_timeout: one subgraph times out via traffic shaping while another returns cacheable data Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: e17a1ee632484f76b8f97c28 ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
aaronArinder
approved these changes
Feb 27, 2026
carodewig
added a commit
that referenced
this pull request
Mar 3, 2026
smyrick
pushed a commit
that referenced
this pull request
Mar 4, 2026
smyrick
pushed a commit
that referenced
this pull request
Mar 17, 2026
smyrick
pushed a commit
that referenced
this pull request
Mar 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a subgraph encounters an error (ie a timeout, ratelimit, etc), and the response cache plugin was going to set a cache-control header, set no-store as the cache-control header instead.
Although this might be a bit wide-sweeping (ie there might be a legitimate issue with the subgraph and retrying the request would not help), it's better for the default to err on the side of not caching rather than caching bad data.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩