fix(composition): emit implements on type definition instead of extend type#8931
Merged
briannafugate408 merged 4 commits intodevfrom Feb 27, 2026
Merged
fix(composition): emit implements on type definition instead of extend type#8931briannafugate408 merged 4 commits intodevfrom
briannafugate408 merged 4 commits intodevfrom
Conversation
Contributor
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: fa52138ca66e9ce294f199ec ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
Contributor
|
@briannafugate408, please consider creating a changeset entry in |
e837baf to
f4d9ea4
Compare
dariuszkuc
reviewed
Feb 27, 2026
|
|
||
| // Exact expected from the task: type line must include "implements DocumentType" and must NOT | ||
| // be split into a separate "extend type ... implements DocumentType". | ||
| assert!( |
Member
There was a problem hiding this comment.
instead of all those asserts why not just have an expected composed schema and assert using insta?
e.g.
assert_snapshot!(supergraph.schema().schema());
dariuszkuc
approved these changes
Feb 27, 2026
smyrick
pushed a commit
that referenced
this pull request
Mar 2, 2026
carodewig
pushed a commit
that referenced
this pull request
Mar 3, 2026
smyrick
pushed a commit
that referenced
this pull request
Mar 17, 2026
smyrick
pushed a commit
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust composition implementation was emitting object types that implement interfaces in a split form. So the SDL had a main type definition without implements and a separate extend type implements block. In merge_implements, we were passing the source subgraph’s ComponentName into insert_implements_interface. When a subgraph had extend type Foo implements I, that name had Extension origin, so the merged schema’s “implements” was attached to an extension component and printed as a separate
extend type ... implements ....Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩