Suggestions for #8915

[carodewig]

I was having a hard time verbalizing my suggestions and found it easier to put them in code.

The key idea is tho separate the validate_otel_envs_not_present into a few parts:

1. Define which environment variables should be rejected programmatically
2. Check for which variables are present in a separate function
3. Create an error based on variables present in a separate function

This is primarily to allow better testing - using unsafe {} code blocks is widely discouraged and separating the pieces allows them to be tested without the use of unsafe blocks.

This change also uses std::env::var rather than std::env::var_os as we need to prohibit non-unicode OTEL vars as well.

[apollo-librarian]

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 2 changed, 0 removed

* graphos/routing/(latest)/security/demand-control.mdx
* graphos/routing/(latest)/security/router-authentication.mdx

Build ID: fe558fd7c5cfc7ecb795e879
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/fe558fd7c5cfc7ecb795e879

---

✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.