-
Notifications
You must be signed in to change notification settings - Fork 337
chore: Update to OpenTelemetry 0.31.0 #8922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 101 commits
Commits
Show all changes
113 commits
Select commit
Hold shift + click to select a range
806a27b
docs: add OpenTelemetry SDK 0.31 migration plan
0965290
deps: upgrade OpenTelemetry dependencies to 0.31
c267f4e
refactor: remove internal datadog_exporter, use external crate
1d60fc5
chore: remove obsolete telemetry code
43ee7fb
fix: update Resource to use builder API
9edc267
fix: replace Key::string()/array() with KeyValue::new()
53a13eb
fix: update instrument builders .init() to .build()
c4a7a65
fix: add parent_span_is_remote field to SpanData
26f48c5
fix: partial OTel 0.31 SDK API migration
9570e32
fix: continue OTel 0.31 SDK migration - tracing and exporter changes
9e08691
fix: migrate OTLP exporter API from new_exporter() to builder pattern
97298de
fix: update ResourceDetector::detect() signature for OTel 0.31
992ff1b
fix: add opentelemetry-datadog to regular dependencies
b968cc8
fix: remove TemporalitySelector code for OTel 0.31
e2f2b28
fix: migrate View API from new_view() to closures for OTel 0.31
9346e75
fix: replace shutdown_tracer_provider() for OTel 0.31
accf1db
fix: migrate Zipkin exporter to builder API for OTel 0.31
35bb88b
fix: update SpanExporter impl for OTel 0.31 API changes
4c596dd
fix: rename TracerProvider to SdkTracerProvider for OTel 0.31
1395dca
fix: update Temporality import path for OTel 0.31
c2fd7f3
docs: update OTel 0.31 migration plan with learnings
7ed8317
deps: upgrade tonic to 0.14.5 for opentelemetry-otlp compatibility
e8d935a
fix: update SpanProcessor implementations for OTel 0.31 API
dea7871
fix: update SpanExporter implementations for OTel 0.31 API
b6811e8
fix: migrate build script to tonic-prost-build 0.14
88b69a0
fix: update ExportError import for OTel 0.31
9ce83a9
fix: update Aggregation import paths for OTel 0.31
b45a9c1
fix: update aggregation.rs for OTel 0.31 metrics API
f9a79d8
fix: remove AggregationSelector in favor of Views API for OTel 0.31
dfe50b1
fix: update MeterProvider and InstrumentProvider APIs for OTel 0.31
9885bca
fix: continue OTel 0.31 SDK API migration
0978de3
fix: continue OTel 0.31 SDK metrics and trace API migration
ceba2ca
fix: complete OTel 0.31 test code API migration
ef8c2d8
fix: metric assertion macro attribute ordering
b93b9c4
fix: Fixes around gauge behaviour and registering of callbacks.
d0512d9
fix: centralize default histogram view to prevent duplicate metrics
a9b2b60
fix: remove duplicate attribute in test assertion
f89a407
fix: Fix duplicate metric attributes. Caused by map turning to list.
eb9928c
fix: use async runtime BatchSpanProcessor for Apollo tracing exporter
4f037ff
fix: update OTLP trace snapshots for OTel 0.31 span flags
cd368d2
fix: prevent OTel SDK errors for observable gauges without readers
2c6eb79
fix: filter OTel 0.31 internal INFO logs from router output
a0013ab
fix: resolve clippy warnings and restore Apollo histogram buckets
8b0e9b0
fix: use async runtime PeriodicReader for Apollo OTLP metrics
a0be142
chore: remove unused Config import in tracer tests
672f759
chore: remove unused imports and mut binding
ccfcc4b
chore: fix unreachable_pub warnings in datadog propagator tests
67ca0dd
fix: clippy
69ec1ca
fix: use async runtime BatchSpanProcessor/PeriodicReader for public O…
d89c8ff
fix: use async runtime BatchSpanProcessor in test infrastructure
6937878
fix: use spawn_blocking for set_tracer_provider during reload
4972817
fix: work around opentelemetry-zipkin 0.31 missing service name
5a0220f
fix: remove test_trace_error test for OTel 0.31
bee260e
fix: support multiple callbacks per observable gauge name
021b1b7
fix: defer Redis metrics creation until Telemetry.activate()
e29fd2d
test: fix flaky subscription passthrough tests
a8d1496
test: increase chaos reload delay to reduce flakiness
4d4dfce
fix: update local datadog exporter for OTel 0.31 API compatibility
fd7d0be
lint fmt
eb6e6f4
chore: fix clippy lint warnings
461357d
Merge branch 'dev' into bryn/otel-0.31-migration
BrynCooke fc30eee
fix: add socket2 dependency with 'all' feature for fred tcp-user-time…
e2935ed
refactor: Make temporality in OTLP config Copy to simplify code
ca9cfdc
refactor: Make view errors panic rather than silently ignoring
8c6202d
refactor: attribute value now panics on unknown otel value conversion
46bddd7
refactor: Move otel export constructor code to consistent location
f591728
fix: readd batch processor concurrent and timeout features.
eaf5ce2
Merge branch 'dev' into bryn/otel-0.31-migration
0817d82
fix: delete accidentally added files (#8941)
BrynCooke 4a263b4
chore: remove exemption for vulnerable protobuf version (#8940)
goto-bus-stop 27fc377
Remove tonic-build dependency (#8938)
rohan-b99 d22261d
Remove duplicate NoopInstrumentProvider (#8945)
rohan-b99 a483909
Use `.into` instead of `Key::new` when calling `Resource::get` for re…
rohan-b99 4417db4
chore: use a resource detector to populate default service name
goto-bus-stop b93d03e
chore: verify & commentate socket2 requirement (#8955)
goto-bus-stop 2692f56
Panic when matching on `opentelemetry::Value` unhandled variant inste…
rohan-b99 c5e63b5
Replace custom `exponential_buckets` fn with `prometheus::exponential…
rohan-b99 7a898aa
Make metrics filter tests simpler by using `.contains` instead of `it…
rohan-b99 50d6a9f
refactor: extend_attributes now uses upsert_attributes (#8949)
BrynCooke 546471e
fix: Add back `apollo.router.telemetry.metrics.cardinality_overflow` …
BrynCooke 86f8e96
chore: remove now-obsolete `MeterProvider.` filter from logging tests…
goto-bus-stop 42d12e1
Ensure `Stream::builder` panics instead of silently failing (#8958)
rohan-b99 3384b7c
Combine `is_registered_for_provider ` and `mark_registered_for_provid…
rohan-b99 7cd59b6
fix: clean shutdown in ApolloOtlpExporter (#8969)
goto-bus-stop 33731bf
Remove unnecessary `with_metrics` calls in metrics configuration test…
rohan-b99 cf18b1d
Always use `periodic_reader_with_async_runtime::PeriodicReader` (#8968)
rohan-b99 ef450ea
feat: add MeteredBatchSpanProcessor for batch processor error metrics…
BrynCooke 831f731
Use `block_in_place` in `reload_tracing` (#8971)
rohan-b99 328decd
Restore Env overrides config.yaml (#8977)
BrynCooke c64301d
rate limit otel log events (#8973)
BrynCooke 7645612
remove dead code
3fe0e36
docs: deprecate native Zipkin exporter in favor of OTLP
9f8d478
Revert "docs: deprecate native Zipkin exporter in favor of OTLP"
0c5312f
chore: expand and harden AggregateMeterProvider trace-silencing durin…
goto-bus-stop b23f6c8
chore: remove sleeps from subscription tests (#8954)
goto-bus-stop 2c82180
docs: deprecate native Zipkin exporter in favor of OTLP (#8978)
BrynCooke 732bea4
Refactor noop meter providers, remove filter and return if no readers…
rohan-b99 510f89b
Merge user-configured metrics views into defaults (#8995)
rohan-b99 04b74db
merge dev
1511194
changeset
db416e7
merge dev
d0831d5
delete unused file
goto-bus-stop 230be7c
Use full "OpenTelemetry" name in changeset
goto-bus-stop 62b7b10
Remove duplicate feature from Cargo.toml
goto-bus-stop 51f145c
chore: reintroduce `test_redis_storage_with_mocks` test (#9010)
goto-bus-stop 518f196
Re-add test_trace_error without the log line assertion as its no long…
rohan-b99 589954d
Revert name change for tokio runtime
4b8dc4c
Merge dev
970f6e4
Change otlp/zipkin/datadog NamedTokioRuntime instances to have -traci…
rohan-b99 f58588e
Fix test_trace_error using "otlp" instead of "otlp-tracing"
rohan-b99 4da2309
tweak waiting in `test_redis_storage_with_mocks` test
goto-bus-stop 99a75cf
Make `cargo machete` happy
goto-bus-stop 638280e
Merge branch 'dev' into bryn/otel-0.31-migration
rohan-b99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| ### Update to Otel 0.31.0 ([PR #8922](https://github.com/apollographql/router/pull/8922)) | ||
|
|
||
| The Router now uses Otel 0.31.0. This update includes many bug fixes and performance improvements from upstream. | ||
|
|
||
| The Router does not guarantee the stability of downstream pre 1.0 APIs so users that directly interact with OTel must update their code accordingly. | ||
|
|
||
| As part of this upgrade Zipkin Native exporter has been deprecated as this is being [deprecated upstream](https://opentelemetry.io/blog/2025/deprecating-zipkin-exporters/). Users should switch to OTLP exporter, which Zipkin now supports natively. | ||
|
|
||
| Zipkin Native exporter also no longer supports setting service name, users that need this should switch to OTLP exporter. | ||
|
|
||
|
|
||
| By [@BrynCooke](https://github.com/BrynCooke) [@goto-bus-stop](https://github.com/goto-bus-stop) [@rohan-b99](https://github.com/rohan-b99) in https://github.com/apollographql/router/pull/8922 | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.