feat(uds): paths by aaronArinder · Pull Request #8894 · apollographql/router

aaronArinder · 2026-02-17T21:39:39Z

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

Exceptions

Note any exceptions here

Notes

It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

apollo-librarian · 2026-02-17T21:39:46Z

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 4 changed, 0 removed

* graphos/routing/(latest)/configuration/yaml.mdx
* graphos/routing/(latest)/customization/coprocessor/index.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/selectors.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/spans.mdx

Build ID: e88179e03589c1cfa39a88e4
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/e88179e03589c1cfa39a88e4

⚠️ AI Style Review — 3 Issues Found

Summary

This pull request updates the documentation to align with several style guide sections. Framing changes prioritize direct, reader-centric instructions using the imperative 'Specify' and referring to 'your' custom paths. Voice and tone are enhanced by incorporating encouraging framing and natural contractions like 'isn't' and 'can't'. Text formatting updates ensure code font is used for the 'url' argument and '.sock' file extensions. Structural elements now consistently introduce lists and code blocks with colons, while avoiding negative phrasing. Finally, product-specific guidance was followed by removing articles before standalone product names like 'Router'.

Duration: 2806ms
Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

mabuyo

Minor comments taking Librarian suggestions as well as keeping similar paragraphs consistent between the pages.

Pre-approving since these changes are non-blocking on docs side!

theJC · 2026-02-18T18:37:21Z

 pub(crate) const MULTIPART_SUBSCRIPTION_SPEC_VALUE: &str = "1.0";
+
+pub(crate) const DEFAULT_SOCKET_PATH: &str = "/";
+pub(crate) const PATH_PREFIX: &str = "path=";


nit: should this be named PATH_QUERY_PARAM ?

works for me!

theJC · 2026-02-18T18:39:41Z

 pub(crate) const MULTIPART_SUBSCRIPTION_SPEC_PARAMETER: &str = "subscriptionSpec";
 pub(crate) const MULTIPART_SUBSCRIPTION_SPEC_VALUE: &str = "1.0";
+
+pub(crate) const DEFAULT_SOCKET_PATH: &str = "/";


Should this one be #[cfg(unix)] otherwise its dead code on non-unix platforms?

oh yeah, good eye

theJC · 2026-02-18T18:58:53Z

+        let converted_uri: http::Uri = if let Some(path) = uri.strip_prefix("unix://") {
+            let (socket_path, http_path) = parse_unix_socket_url(path);
+            hyperlocal::Uri::new(&socket_path, &http_path).into()
        } else {
            uri.parse()?
        };


Would it make sense/be better to do the parse_unix_socket_url call once at configuration time and not on the every request hot-path (similar to whats done in plugins/override_url.rs new) ?

maybe but only if it proves to be a problem; I suspect it won't be, but changing the APIs of both the router and supergraph builders will introduce a lot of mess

happy to have @carodewig say otherwise though; details: we'd need to add uri to the router and supergraph builders in the external service, and we'd also need to string through the right uri from the relevant callsites (eg, for router, we'd need to inject it from both the router request and response stages for coprocessors)

I agree with your assessment and maybe its something to consider doing later down the road if deemed necessary or more natural with the rest of the codebase. Im just in the habit of trying by default to shed anything possible from the hot request codepath....

theJC · 2026-02-18T19:12:38Z

+
+#[cfg(unix)]
+#[cfg(test)]
+mod unix_socket_url_tests {


2 additional tests should be added here:

parse_socket_path_with_empty_path_param: ?path

parse_socket_path_without_leading_slash: ?path=no_leading_slash

done! and rstest-ified

carodewig · 2026-02-18T18:58:45Z

@@ -0,0 +1,6 @@
+### Enable Unix Domain Socket paths ([PR #8894](https://github.com/apollographql/router/pull/8894))
+
+Enables Unix Domain Socket (UDS) paths for both coprocessors and subgraphs. The paths _must_ use `?path=` as their delimiter: `unix:///tmp/some.sock?path=some_path`


I don't think ?path= is really the delimiter - isn't it ?? Based on url_path.find('?')

ahh, it is, yeah; I was trying to stress that folks must use ?path= rather than something like ?whatever= because we match on path

I'll think through better wording

Co-authored-by: Michelle Mabuyo <michelle@apollographql.com>

rohan-b99 · 2026-02-20T15:46:53Z

+/// Requires:
+/// - when using query params, the param must be denoted by `?path=`
+#[cfg(unix)]
+pub(crate) fn parse_unix_socket_url(url_path: &str) -> (String, String) {


Nitpick, but is there any reason why this can't return (&str, &str)?

nope! fixing

theJC · 2026-02-25T02:44:15Z

I dont have permission to mark my feedback items as resolved, but please consider them resolved/freel free to close them out.

carodewig · 2026-02-27T15:21:40Z

+    )]
+    fn parse_socket_url(
+        #[case] input: &str,
+        #[case] expected_socket: &str,


Nit: it looks like all the tests have the same expected_socket, so this param could be removed

theJC · 2026-03-06T16:59:09Z

Checking in here. We've upgraded to 2.12.0, and are anxiously awaiting this capability ;)

aaronArinder · 2026-03-06T18:00:01Z

I should be able to return to it next week (had an urgent interrupt that's nearly over); sorry it's taken so long! I still owe you another PR too, though I need to check my notes on what it was for (mostly trying to broadcast that this hasn't been forgotten, just a necessary backburnering for a short while)

…

On Fri, Mar 6, 2026 at 11:59 AM Jon Christiansen ***@***.***> wrote: *theJC* left a comment (apollographql/router#8894) <#8894 (comment)> Checking in here. We've upgraded to 2.12.0, and are anxiously awaiting this capability ;) — Reply to this email directly, view it on GitHub <#8894 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGMABHEHX7IZTVI7PD4MIVD4PL7XNAVCNFSM6AAAAACVOWYLMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMJSHA4TKMRWGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Co-authored-by: Michelle Mabuyo <michelle@apollographql.com>

aaronArinder requested review from a team as code owners February 17, 2026 21:39

aaronArinder force-pushed the aaron/uds-paths branch from d5c2d60 to 9e28f7d Compare February 17, 2026 21:40

aaronArinder marked this pull request as draft February 17, 2026 21:55

aaronArinder force-pushed the aaron/uds-paths branch 3 times, most recently from f77101a to ed38fd0 Compare February 18, 2026 14:30

feat(uds): paths

f350b71

aaronArinder force-pushed the aaron/uds-paths branch from ed38fd0 to f350b71 Compare February 18, 2026 14:37

aaronArinder marked this pull request as ready for review February 18, 2026 14:42

mabuyo approved these changes Feb 18, 2026

View reviewed changes

Comment thread docs/source/routing/configuration/yaml.mdx Outdated

Comment thread docs/source/routing/configuration/yaml.mdx Outdated

Comment thread docs/source/routing/customization/coprocessor/index.mdx Outdated

theJC reviewed Feb 18, 2026

View reviewed changes

carodewig reviewed Feb 18, 2026

View reviewed changes

aaronArinder and others added 8 commits February 20, 2026 10:04

Update docs/source/routing/configuration/yaml.mdx

32530d4

Co-authored-by: Michelle Mabuyo <michelle@apollographql.com>

Update docs/source/routing/configuration/yaml.mdx

1bba134

Co-authored-by: Michelle Mabuyo <michelle@apollographql.com>

Update docs/source/routing/customization/coprocessor/index.mdx

dc20de2

Co-authored-by: Michelle Mabuyo <michelle@apollographql.com>

fix: rename var

ac1673f

fix: unix-only var

3d7dc2c

fix: rstest-ify parse_unix_socket_url tests

6eb23b9

fix: changeset wording

1aa6f94

fix: lint

c6e3fbf

rohan-b99 reviewed Feb 20, 2026

View reviewed changes

fix: parse_unix_socket_url api

5eb6d58

aaronArinder force-pushed the aaron/uds-paths branch from c767d9f to ad82dc6 Compare February 20, 2026 20:19

fix: lint

98733ca

aaronArinder force-pushed the aaron/uds-paths branch from ad82dc6 to 98733ca Compare February 20, 2026 20:24

aaronArinder requested a review from rohan-b99 February 23, 2026 14:57

rohan-b99 approved these changes Feb 27, 2026

View reviewed changes

carodewig approved these changes Feb 27, 2026

View reviewed changes

aaronArinder merged commit 7770530 into dev Mar 12, 2026
15 checks passed

aaronArinder deleted the aaron/uds-paths branch March 12, 2026 14:27

smyrick pushed a commit that referenced this pull request Mar 17, 2026

feat(uds): paths (#8894)

5020bf2

Co-authored-by: Michelle Mabuyo <michelle@apollographql.com>

smyrick pushed a commit that referenced this pull request Mar 20, 2026

feat(uds): paths (#8894)

8d86f25

Co-authored-by: Michelle Mabuyo <michelle@apollographql.com>

abernix mentioned this pull request Mar 31, 2026

prep release: v2.13.0 #9104

Merged

		@@ -0,0 +1,6 @@
		### Enable Unix Domain Socket paths ([PR #8894](https://github.com/apollographql/router/pull/8894))

		Enables Unix Domain Socket (UDS) paths for both coprocessors and subgraphs. The paths _must_ use `?path=` as their delimiter: `unix:///tmp/some.sock?path=some_path`

Conversation

aaronArinder commented Feb 17, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Footnotes

Uh oh!

apollo-librarian bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Docs preview ready

⚠️ AI Style Review — 3 Issues Found

Uh oh!

mabuyo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theJC Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theJC Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theJC commented Feb 25, 2026

Uh oh!

carodewig Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theJC commented Mar 6, 2026

Uh oh!

aaronArinder commented Mar 6, 2026 via email

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aaronArinder commented Feb 17, 2026 •

edited by atlassian bot

Loading

apollo-librarian bot commented Feb 17, 2026 •

edited

Loading

theJC Feb 18, 2026 •

edited

Loading

theJC Feb 21, 2026 •

edited

Loading

carodewig Feb 27, 2026 •

edited

Loading