Skip to content

listSize directive parsing improvements#8893

Merged
morriswchris merged 4 commits intodevfrom
GRAPHOS-4/cmo/list-size-advanced-parsing
Feb 17, 2026
Merged

listSize directive parsing improvements#8893
morriswchris merged 4 commits intodevfrom
GRAPHOS-4/cmo/list-size-advanced-parsing

Conversation

@morriswchris
Copy link
Copy Markdown
Contributor

@morriswchris morriswchris commented Feb 17, 2026

Improvements to @listSize argument parsing:

  • Array parsing for @listSize: List-size directives can use array-style parsing for sizing (e.g. list arguments). This allows queries like itemsByUUID(ids: [ID!]) to be accurately costed
  • Nested input paths: Nested input paths are supported when resolving list size from query arguments.
  • Nested sizedFields: The sizedFields argument on @listSize supports nested field paths for more accurate cost estimation.

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Docs will follow in a separate PR.

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@morriswchris morriswchris requested a review from a team as a code owner February 17, 2026 15:57
@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Feb 17, 2026

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 95f10aa02f3b963a7fc913bf
Build Logs: View logs

@github-actions

This comment has been minimized.

@morriswchris morriswchris self-assigned this Feb 17, 2026
Copy link
Copy Markdown
Contributor

@aaronArinder aaronArinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamp for already-reviewed code (apart from changeset, which looks good)

@morriswchris morriswchris merged commit 8acf05c into dev Feb 17, 2026
15 checks passed
@morriswchris morriswchris deleted the GRAPHOS-4/cmo/list-size-advanced-parsing branch February 17, 2026 16:17
@abernix abernix mentioned this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants