Skip to content

Bug: Connectors content-type header duplication#8867

Merged
andrewmcgivery merged 5 commits intodevfrom
am/connectors_content_type_header_duplication
Feb 9, 2026
Merged

Bug: Connectors content-type header duplication#8867
andrewmcgivery merged 5 commits intodevfrom
am/connectors_content_type_header_duplication

Conversation

@andrewmcgivery
Copy link
Copy Markdown
Contributor

When using connectors and overriding the content-type header, the default value was still set. Setting the content-type header will now properly override the value.

For example:

@source(
    name: "datasetInsightsAPI"
    http: {
        headers: [
            { name: "Content-Type", value: "application/vnd.iaas.v1+json" },
        ]
    }
)

Would result in:

content-type: application/json, application/vnd.iaas.v1+json

After this change, it will instead result in:

content-type: application/vnd.iaas.v1+json

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

…e default value was still set. Setting the content-type header will now properly override the value.
@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Feb 5, 2026

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: f04325b97aa02133fafa5a6c
Build Logs: View logs

@github-actions

This comment has been minimized.

@andrewmcgivery andrewmcgivery marked this pull request as ready for review February 5, 2026 22:24
@andrewmcgivery andrewmcgivery requested review from a team as code owners February 5, 2026 22:24
Copy link
Copy Markdown
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @andrewmcgivery!

@andrewmcgivery andrewmcgivery enabled auto-merge (squash) February 6, 2026 17:53
Copy link
Copy Markdown
Contributor

@pragl pragl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewmcgivery andrewmcgivery merged commit 7d61778 into dev Feb 9, 2026
14 checks passed
@andrewmcgivery andrewmcgivery deleted the am/connectors_content_type_header_duplication branch February 9, 2026 17:59
@abernix abernix mentioned this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants