Skip to content

feat(redis): default timeout bumped to 10s#8863

Merged
aaronArinder merged 4 commits intodevfrom
aaron/bump-up-internal-redis-conn-timeout
Feb 10, 2026
Merged

feat(redis): default timeout bumped to 10s#8863
aaronArinder merged 4 commits intodevfrom
aaron/bump-up-internal-redis-conn-timeout

Conversation

@aaronArinder
Copy link
Copy Markdown
Contributor

@aaronArinder aaronArinder commented Feb 4, 2026


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@aaronArinder aaronArinder requested a review from a team February 4, 2026 21:01
@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Feb 4, 2026

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 98bbff34cf900392a6870fd0
Build Logs: View logs

@github-actions

This comment has been minimized.

@aaronArinder aaronArinder force-pushed the aaron/bump-up-internal-redis-conn-timeout branch from fb1804c to df094fc Compare February 4, 2026 21:08
@aaronArinder aaronArinder requested a review from a team as a code owner February 4, 2026 21:09
Copy link
Copy Markdown
Contributor

@carodewig carodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good - appreciate the inline docs! Just a few changeset suggestions

Comment thread .changesets/fix_low_redis_timeout.md Outdated
Comment thread .changesets/fix_low_redis_timeout.md Outdated
carodewig

This comment was marked as duplicate.

Copy link
Copy Markdown
Contributor

@pragl pragl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

aaronArinder and others added 4 commits February 10, 2026 09:39
Co-authored-by: Caroline Rodewig <16093297+carodewig@users.noreply.github.com>
Co-authored-by: Caroline Rodewig <16093297+carodewig@users.noreply.github.com>
@aaronArinder aaronArinder force-pushed the aaron/bump-up-internal-redis-conn-timeout branch from c75badc to 289f58c Compare February 10, 2026 14:39
@aaronArinder aaronArinder enabled auto-merge (squash) February 10, 2026 14:40
@aaronArinder aaronArinder merged commit 203d360 into dev Feb 10, 2026
15 checks passed
@aaronArinder aaronArinder deleted the aaron/bump-up-internal-redis-conn-timeout branch February 10, 2026 15:02
@abernix abernix mentioned this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants