Skip to content

fix(composition): partial revert removing single element list to non-list coercion #8848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briannafugate408 merged 2 commits into from
Feb 2, 2026
Merged

fix(composition): partial revert removing single element list to non-list coercion #8848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
041fc5a
fix(composition): partial revert removing single element list to non …
briannafugate408 Feb 2, 2026
ff6e994
Merge branch 'dev' into FED-773-partial-revert
briannafugate408 Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions apollo-federation/src/compat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,6 @@ fn coerce_value(
coerce_value(types, element, ty.item_type())?;
}
}
// Coerce single-element list to a non-list type.
// This is the reverse of the scalar-to-list coercion below.
(Value::List(list), Some(_)) if !ty.is_list() && list.len() == 1 => {
let element = list.pop().unwrap();
*target.make_mut() = element.as_ref().clone();
coerce_value(types, target, ty)?;
}
// Coerce single values (except null) to a list.
(
Value::Object(_)
Expand Down
Loading