fix(composition): Don't skip optional args in witness operations for satisfiability errors#8847
Merged
dariuszkuc merged 1 commit intodevfrom Jan 30, 2026
Conversation
Contributor
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 78536409f80622a48a9318e1 |
Contributor
|
@sachindshinde, please consider creating a changeset entry in |
…isfiability witness operations
sachindshinde
force-pushed
the
sachin/dont-skip-optional-args-in-satisfiability-witness-ops
branch
from
3e09ea3 to
db9b2d0
Compare
dariuszkuc
approved these changes
Jan 30, 2026
dariuszkuc
deleted the
sachin/dont-skip-optional-args-in-satisfiability-witness-ops
branch
the-gigi-apollo
pushed a commit
that referenced
this pull request
Feb 4, 2026
…satisfiability errors (#8847) This PR updates satisfiability error messaging to align more with JS code to facilitate validation. Specifically, this PR updates witness operation generation logic to include optional arguments.
briannafugate408
pushed a commit
that referenced
this pull request
Feb 4, 2026
…satisfiability errors (#8847) This PR updates satisfiability error messaging to align more with JS code to facilitate validation. Specifically, this PR updates witness operation generation logic to include optional arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates satisfiability error messaging to align more with JS code to facilitate validation. Specifically, this PR updates witness operation generation logic to include optional arguments.