Add documentation and tests for dollar sign escaping in config#8841
Merged
robert113289 merged 1 commit intodevfrom Jan 28, 2026
Merged
Add documentation and tests for dollar sign escaping in config#8841robert113289 merged 1 commit intodevfrom
robert113289 merged 1 commit intodevfrom
Conversation
Contributor
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: c6b32651f7b0048548f199e9 URL: https://www.apollographql.com/docs/deploy-preview/c6b32651f7b0048548f199e9 |
Contributor
|
@robert113289, please consider creating a changeset entry in |
97289b6 to
c1e6cc7
Compare
SharkBaitDLS
approved these changes
Jan 28, 2026
the-gigi-apollo
pushed a commit
that referenced
this pull request
Feb 4, 2026
briannafugate408
pushed a commit
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a documentation PR that adds a unit test. No production code changes.
This PR documents the
$$escape syntax for including literal dollar signs in router YAML configuration values. This syntax is supported by the underlying shellexpand crate but was previously undocumented, causing user confusion in apollographql/rover#2737 .some$$api$$key→some$api$keyChecklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩