Skip to content

Add documentation and tests for dollar sign escaping in config#8841

Merged
robert113289 merged 1 commit intodevfrom
kirkum/document-yaml-escaping
Jan 28, 2026
Merged

Add documentation and tests for dollar sign escaping in config#8841
robert113289 merged 1 commit intodevfrom
kirkum/document-yaml-escaping

Conversation

@robert113289
Copy link
Copy Markdown
Contributor

This is a documentation PR that adds a unit test. No production code changes.

This PR documents the $$ escape syntax for including literal dollar signs in router YAML configuration values. This syntax is supported by the underlying shellexpand crate but was previously undocumented, causing user confusion in apollographql/rover#2737 .

  • Adds new "Escaping special characters" section to the YAML configuration reference
  • Example: some$$api$$keysome$api$key

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Jan 28, 2026

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* graphos/routing/(latest)/configuration/yaml.mdx

Build ID: c6b32651f7b0048548f199e9
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/c6b32651f7b0048548f199e9

@github-actions
Copy link
Copy Markdown
Contributor

@robert113289, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@robert113289 robert113289 force-pushed the kirkum/document-yaml-escaping branch from 97289b6 to c1e6cc7 Compare January 28, 2026 22:38
@robert113289 robert113289 marked this pull request as ready for review January 28, 2026 23:22
@robert113289 robert113289 requested a review from a team January 28, 2026 23:22
@robert113289 robert113289 requested a review from a team as a code owner January 28, 2026 23:22
@robert113289 robert113289 merged commit ac4b4bb into dev Jan 28, 2026
13 checks passed
@robert113289 robert113289 deleted the kirkum/document-yaml-escaping branch January 28, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants