Skip to content

fix(tests): split stdout/stderr into separate channels#8839

Merged
aaronArinder merged 1 commit intodevfrom
aaron/fix-common-int
Feb 3, 2026
Merged

fix(tests): split stdout/stderr into separate channels#8839
aaronArinder merged 1 commit intodevfrom
aaron/fix-common-int

Conversation

@aaronArinder
Copy link
Copy Markdown
Contributor


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@aaronArinder aaronArinder requested a review from a team January 28, 2026 18:01
@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Jan 28, 2026

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: b61e8a4ebd8f2ef58de360b1
Build Logs: View logs

@github-actions
Copy link
Copy Markdown
Contributor

@aaronArinder, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

Copy link
Copy Markdown
Contributor

@carodewig carodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Only question is whether any of the tests rely on stderr being captured - but if CI passes that shouldn't be a problem

@aaronArinder
Copy link
Copy Markdown
Contributor Author

aaronArinder commented Jan 28, 2026 via email

@aaronArinder aaronArinder merged commit de08fc5 into dev Feb 3, 2026
15 checks passed
@aaronArinder aaronArinder deleted the aaron/fix-common-int branch February 3, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants