fix(tests): split stdout/stderr into separate channels#8839
Merged
aaronArinder merged 1 commit intodevfrom Feb 3, 2026
Merged
Conversation
Contributor
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: b61e8a4ebd8f2ef58de360b1 |
Contributor
|
@aaronArinder, please consider creating a changeset entry in |
carodewig
reviewed
Jan 28, 2026
Contributor
carodewig
left a comment
There was a problem hiding this comment.
Good find! Only question is whether any of the tests rely on stderr being captured - but if CI passes that shouldn't be a problem
Contributor
Author
|
nope! at least locally (and for the first ci run, which I reran for an
unrelated thing)
…On Wed, Jan 28, 2026 at 1:37 PM Caroline Rodewig ***@***.***> wrote:
***@***.**** commented on this pull request.
Good find! Only question is whether any of the tests rely on stderr being
captured - but if CI passes that shouldn't be a problem
—
Reply to this email directly, view it on GitHub
<#8839 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMABHD3274WK4CATLA2XYL4JD6WLAVCNFSM6AAAAACTGVL3SOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTOMJYGM3TEMJXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
carodewig
approved these changes
Feb 3, 2026
the-gigi-apollo
pushed a commit
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩