Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changesets/fix_bnjjj_fix_invalidation_error.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Response cache: returns error when you have an error invalidating data ([PR #8813](https://github.com/apollographql/router/pull/8813))

Without this fix it will never throw an error. Once you deploy this change you might see some increase in `apollo.router.operations.response_cache.invalidation.error` metric.

By [@bnjjj](https://github.com/bnjjj) in https://github.com/apollographql/router/pull/8813
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ impl CacheStorage for Storage {
let mut counts = HashMap::with_capacity(num_subgraphs);
while let Some(result) = join_set.join_next().await {
let (subgraph_name, count) = result?;
counts.insert(subgraph_name, count.unwrap_or(0));
counts.insert(subgraph_name, count?);
}

Ok(counts)
Expand Down