feat: support subgraph-level demand control#8800
Closed
Conversation
Contributor
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 2 changed, 0 removedBuild ID: b52304f001e34e72e4689a10 URL: https://www.apollographql.com/docs/deploy-preview/b52304f001e34e72e4689a10 |
Contributor
|
@carodewig, please consider creating a changeset entry in |
10 tasks
Contributor
Author
|
Superseded by #8829 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to configure a maximum cost (and list size) per subgraph, rather than relying solely on a whole-query cost limit.
The new configuration looks something like:
Consider a
topProductsquery, which fetches a list of products from aproductssubgraph and then performs an entity lookup for each product in areviewssubgraph. Assume that theproductscost is 10 and thereviewscost is 5, leading to a total estimated cost of 15 (10 + 5).Previously, you would only be able to restrict that query via
demand_control.static_estimated.max:This feature allows much more granular control. In addition to
demand_control.static_estimated.max, which operates as before, there are also per subgraph maxes.For example, if you set
max20 andreviews.maxas 2, the query will 'pass' the aggregate check (15 < 20) and will execute on theproductssubgraph (no limit specified), but will not execute against thereviewssubgraph (5 > 2). The result will be composed as if thereviewssubgraph had returned null.TODOs:
static_estimated. this is required to support the following itemright now, the
actualcomputation seems to mostly reflect the shape of the output, not how much work had to be done to get there. as an example, if you have two subgraphsABand a query path that goesquery(A) -> entities fetch(B) -> entities fetch(A), the actual cost doesn't include the 'hidden' fields fromA/Bthat made that query path possible (ie ids).Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩