Skip to content

fix: tls connections hanging when any connection does not complete handshake#8779

Merged
rohan-b99 merged 10 commits intodevfrom
rohan-b99/tls-connections-hang-when-any-handshake-not-complete
Jan 7, 2026
Merged

fix: tls connections hanging when any connection does not complete handshake#8779
rohan-b99 merged 10 commits intodevfrom
rohan-b99/tls-connections-hang-when-any-handshake-not-complete

Conversation

@rohan-b99
Copy link
Contributor

@rohan-b99 rohan-b99 commented Dec 22, 2025

Ensures the main listener loop is not blocked when waiting for a TLS handshake to complete


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

To test:
Run the router with : cargo run -- -c apollo-router/tests/integration/fixtures/tls.router.yml -s examples/graphql/supergraph.graphql
In a new terminal, run: nc 127.0.0.1 <router-port>
In another terminal, run: curl -v -k https://127.0.0.1:<router-port>
The curl command should complete successfully

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@rohan-b99 rohan-b99 requested a review from a team December 22, 2025 12:37
@apollo-librarian
Copy link

apollo-librarian bot commented Dec 22, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* graphos/routing/(latest)/configuration/yaml.mdx

Build ID: 996694ab363b207d17ed91bf
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/996694ab363b207d17ed91bf

@github-actions

This comment has been minimized.

@rohan-b99 rohan-b99 changed the title Fix tls connections hanging when any connection does not complete handshake fix: tls connections hanging when any connection does not complete handshake Jan 5, 2026
@rohan-b99 rohan-b99 requested a review from a team as a code owner January 5, 2026 17:24
Copy link
Contributor

@carodewig carodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall!

Copy link
Contributor

@carodewig carodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd suggest applying the AI style review bot's suggestions, but code changes look great

@rohan-b99 rohan-b99 merged commit 5726ed0 into dev Jan 7, 2026
15 checks passed
@rohan-b99 rohan-b99 deleted the rohan-b99/tls-connections-hang-when-any-handshake-not-complete branch January 7, 2026 16:55
@abernix abernix mentioned this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments