Skip to content

fix(exec::Req): pub(crate) -> pub, fixes public api#8771

Merged
aaronArinder merged 2 commits intodevfrom
aaron/fix-public-api-for-exec-req
Jan 6, 2026
Merged

fix(exec::Req): pub(crate) -> pub, fixes public api#8771
aaronArinder merged 2 commits intodevfrom
aaron/fix-public-api-for-exec-req

Conversation

@aaronArinder
Copy link
Contributor

@aaronArinder aaronArinder commented Dec 17, 2025


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@aaronArinder aaronArinder requested a review from a team December 17, 2025 20:42
@aaronArinder aaronArinder requested a review from a team as a code owner December 17, 2025 20:42
@apollo-librarian
Copy link

apollo-librarian bot commented Dec 17, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: d881fcdbc044ba8e60f4fc18
Build Logs: View logs

@aaronArinder aaronArinder force-pushed the aaron/fix-public-api-for-exec-req branch from afb08d9 to a20565e Compare December 17, 2025 20:43
@aaronArinder aaronArinder force-pushed the aaron/fix-public-api-for-exec-req branch from a20565e to 7274661 Compare December 19, 2025 14:32
@aaronArinder aaronArinder enabled auto-merge (squash) January 5, 2026 15:44
@aaronArinder aaronArinder force-pushed the aaron/fix-public-api-for-exec-req branch from 10a2f44 to d175dc8 Compare January 5, 2026 18:52
@aaronArinder aaronArinder force-pushed the aaron/fix-public-api-for-exec-req branch from d175dc8 to 94f0874 Compare January 6, 2026 15:08
@aaronArinder aaronArinder merged commit 227772d into dev Jan 6, 2026
15 checks passed
@aaronArinder aaronArinder deleted the aaron/fix-public-api-for-exec-req branch January 6, 2026 15:33
@abernix abernix mentioned this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants