Skip to content

Send overflow metric for more cardinality errors#8740

Merged
bonnici merged 3 commits intodevfrom
njm/INS-1924/fix-cardinality-overflow
Dec 9, 2025
Merged

Send overflow metric for more cardinality errors#8740
bonnici merged 3 commits intodevfrom
njm/INS-1924/fix-cardinality-overflow

Conversation

@bonnici
Copy link
Contributor

@bonnici bonnici commented Dec 9, 2025


Emit the apollo.router.telemetry.metrics.cardinality_overflow metric for more instances where an OTel cardinality error has occurred. The message check has been changed to support a different form of the error that has been reported by a customer.

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@bonnici bonnici requested a review from a team December 9, 2025 03:09
@github-actions

This comment has been minimized.

@apollo-librarian
Copy link

apollo-librarian bot commented Dec 9, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 37beffa916f6b8d36a1c44d8
Build Logs: View logs

@bonnici bonnici requested a review from a team December 9, 2025 03:10
@bonnici bonnici requested a review from a team as a code owner December 9, 2025 03:13
Copy link
Contributor

@timbotnik timbotnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@bonnici bonnici merged commit c6e52d2 into dev Dec 9, 2025
15 checks passed
@bonnici bonnici deleted the njm/INS-1924/fix-cardinality-overflow branch December 9, 2025 09:23
@abernix abernix mentioned this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants