feat: Add startup warning for OTEL_EXPORTER_OTLP_ENDPOINT environment…#8729
Merged
feat: Add startup warning for OTEL_EXPORTER_OTLP_ENDPOINT environment…#8729
Conversation
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 10 changed, 0 removedBuild ID: bce0d0a11966d1959e89eea3 URL: https://www.apollographql.com/docs/deploy-preview/bce0d0a11966d1959e89eea3 |
bonnici
reviewed
Dec 8, 2025
Contributor
Author
|
Apologies, I was testing something earlier with schema.json and accidentally left it in. It has now been removed. |
bonnici
approved these changes
Dec 9, 2025
abernix
approved these changes
Dec 11, 2025
briannafugate408
pushed a commit
that referenced
this pull request
Jan 9, 2026
…t… (#8729) Co-authored-by: Jesse Rosenberger <git@jro.cc>
briannafugate408
pushed a commit
that referenced
this pull request
Jan 21, 2026
…t… (#8729) Co-authored-by: Jesse Rosenberger <git@jro.cc>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a startup warning to alert users when the
OTEL_EXPORTER_OTLP_ENDPOINTenvironment variable is set.The warning message informs users that this environment variable takes precedence over default router configurations and may override trace export to Apollo Studio, which could cause unexpected behavior in telemetry collection.
Motivation
Users may accidentally set
OTEL_EXPORTER_OTLP_ENDPOINTglobally or in their deployment configuration without realizing it takes precedence over the router's configured telemetry settings. This can silently redirect traces away from Apollo Studio, making it difficult to diagnose why traces are not appearing.Changes
apollo-router/src/executable.rsduring router startupOTEL_EXPORTER_OTLP_ENDPOINTis detectedChecklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
env::var()check during startup (one-time operation).Testing
Manual Testing
To verify this change: