Ensure http.server.response.body.size metric is recorded

[rohan-b99]

---

To test, use this config:

telemetry:
  instrumentation:
    instruments:
      router:
        http.server.response.body.size: true
  exporters:
    metrics:
      prometheus:
        enabled: true
        listen: 127.0.0.1:9000
        path: /metrics

Send a request to the router:
curl -v http://localhost:4000/ -H "Content-Type: application/json" -d '{"query": "{ __typename }"}'

Go to http://localhost:9000/metrics
Search for http_server_response_body_size - see there is a match that corresponds to the returned content length

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

• PR description explains the motivation for the change and relevant context for reviewing
• PR description links appropriate GitHub/Jira tickets (creating when necessary)
• Changeset is included for user-facing changes
• Changes are compatible¹
• Documentation² completed
• Performance impact assessed and acceptable
• Metrics and logs are added³ and documented
• Tests added and passing⁴
  • Unit tests
  • Integration tests
  • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices. ↩

4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

[apollo-librarian]

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed

* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/instruments.mdx

Build ID: 08ec1f75eba63b2511e88bf0
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/08ec1f75eba63b2511e88bf0

[TylerBloom]

Is there a reason these are going from true to false?

[rohan-b99]

The default requirement level (Required) enabled them by default, they didn't show up before as content-length was not specified in the test yaml but since we now do it based on the body it would show up if not disabled here. I figured it would be best to disable it for the tests not relating to response body size so it doesn't show up in the snapshots