Fix: Update diy Dockerfile.repo to prevent glibc incompatibilities (copy #8452)#8629
Fix: Update diy Dockerfile.repo to prevent glibc incompatibilities (copy #8452)#8629
Conversation
|
@mergify[bot]: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 3 changed, 0 removedBuild ID: b4d278003816f92f31105598 URL: https://www.apollographql.com/docs/deploy-preview/b4d278003816f92f31105598 |
This comment has been minimized.
This comment has been minimized.
(cherry picked from commit 764f280)
5e22cb0 to
555d5e0
Compare
abernix
left a comment
There was a problem hiding this comment.
@BrynCooke requesting your review of this, per #8452.
I'll actually un-approve this just until I write the changelog for it.
There was a problem hiding this comment.
@BrynCooke A final stamp from you would good. Please feel free to squash-merge if you approve.
@theJC I filled out the changeset, in case you wanted to hold my feet to the fire about nuances in explaining it, but it could be good enough as is. Thanks again!
Fixes: #8450
There is a glibc incompatibility due to using the base
rustdocker image to build the router binary, but then usingdebian bookworm-slimfor runtime that results in an unusable image.This is the resulting failure when attempting to start:
/dist/router: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.39' not found (required by /dist/router)This transitions to build using
rust:1.91.1-slim-bookwormto address this issue.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
This is an automatic copy of pull request #8452 done by [Mergify](https://mergify.com).
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩