Skip to content

Fix: Update diy Dockerfile.repo to prevent glibc incompatibilities (copy #8452)#8629

Merged
abernix merged 5 commits intodevfrom
mergify/copy/dev/pr-8452
Nov 24, 2025
Merged

Fix: Update diy Dockerfile.repo to prevent glibc incompatibilities (copy #8452)#8629
abernix merged 5 commits intodevfrom
mergify/copy/dev/pr-8452

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Nov 18, 2025

Fixes: #8450

There is a glibc incompatibility due to using the baserust docker image to build the router binary, but then using debian bookworm-slim for runtime that results in an unusable image.

This is the resulting failure when attempting to start:
/dist/router: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.39' not found (required by /dist/router)

This transitions to build using rust:1.91.1-slim-bookworm to address this issue.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes


This is an automatic copy of pull request #8452 done by [Mergify](https://mergify.com).

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@apollo-cla
Copy link
Copy Markdown

@mergify[bot]: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Nov 18, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 3 changed, 0 removed
* graphos/routing/(latest)/observability/graphos/graphos-reporting.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/telemetry-pipelines/metrics-exporters/otlp.mdx
* graphos/routing/(latest)/observability/router-telemetry-otel/telemetry-pipelines/trace-exporters/otlp.mdx

Build ID: b4d278003816f92f31105598
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/b4d278003816f92f31105598

@github-actions

This comment has been minimized.

@abernix abernix force-pushed the mergify/copy/dev/pr-8452 branch from 5e22cb0 to 555d5e0 Compare November 18, 2025 17:56
abernix
abernix previously approved these changes Nov 18, 2025
Copy link
Copy Markdown
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrynCooke requesting your review of this, per #8452.

Comment thread dockerfiles/diy/dockerfiles/Dockerfile.repo Outdated
@abernix abernix self-assigned this Nov 18, 2025
@abernix abernix dismissed their stale review November 18, 2025 18:00

I'll actually un-approve this just until I write the changelog for it.

@abernix abernix requested a review from a team as a code owner November 19, 2025 16:37
Copy link
Copy Markdown
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrynCooke A final stamp from you would good. Please feel free to squash-merge if you approve.

@theJC I filled out the changeset, in case you wanted to hold my feet to the fire about nuances in explaining it, but it could be good enough as is. Thanks again!

@abernix abernix enabled auto-merge (squash) November 19, 2025 16:41
@abernix abernix disabled auto-merge November 19, 2025 16:41
@abernix abernix enabled auto-merge (squash) November 24, 2025 11:35
@abernix abernix merged commit d0d8431 into dev Nov 24, 2025
15 checks passed
@abernix abernix deleted the mergify/copy/dev/pr-8452 branch November 24, 2025 11:56
@abernix abernix mentioned this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dockerfiles/diy/dockerfiles/Dockerfile.repo builds an unusable image due to rust 19.0 vs bookworm glibc incompatibility

3 participants