Skip to content

FIX PR-8415 build due to doc issue: Add description in example in instruments.mdx#8425

Merged
bnjjj merged 2 commits intoapollographql:mergify/copy/dev/pr-8415from
theJC:mergify/copy/dev/pr-8415
Oct 15, 2025
Merged

FIX PR-8415 build due to doc issue: Add description in example in instruments.mdx#8425
bnjjj merged 2 commits intoapollographql:mergify/copy/dev/pr-8415from
theJC:mergify/copy/dev/pr-8415

Conversation

@theJC
Copy link
Contributor

@theJC theJC commented Oct 15, 2025

Address build error with instruments.mdx:

--- STDERR:              apollo-router configuration::tests::validate_project_config_files ---

thread 'configuration::tests::validate_project_config_files' panicked at apollo-router\src\configuration\tests.rs:469:21:
../docs\source\routing\observability\router-telemetry-otel\enabling-telemetry\instruments.mdx configuration error: 
configuration had errors: 
1. at line 7

    instrumentation:
      instruments:
        router:
          # Recommended: use seconds (values recorded as seconds)
┌         acme.request.duration:
|           value: duration
|           type: histogram
|           unit: s
└-----> "description" is a required property

2. at line 13

            type: histogram
            unit: s
  
          # Only if required by your observability platform
┌         otheracme.request.duration:
|           value: duration
|           type: histogram
|           unit: ms # Values automatically converted to milliseconds
└-----> "description" is a required property

@theJC theJC requested a review from a team as a code owner October 15, 2025 16:12
@theJC theJC changed the title Add description in example in instruments.mdx FIX BUILD IN MR: Add description in example in instruments.mdx Oct 15, 2025
@theJC theJC changed the title FIX BUILD IN MR: Add description in example in instruments.mdx FIX BUILD IN PR-8415 due to doc: Add description in example in instruments.mdx Oct 15, 2025
@theJC theJC changed the title FIX BUILD IN PR-8415 due to doc: Add description in example in instruments.mdx FIX BUILD IN PR-8415 due to doc issue: Add description in example in instruments.mdx Oct 15, 2025
@theJC theJC changed the title FIX BUILD IN PR-8415 due to doc issue: Add description in example in instruments.mdx FIX PR-8415 build due to doc issue: Add description in example in instruments.mdx Oct 15, 2025
@bnjjj bnjjj merged commit 7c098a9 into apollographql:mergify/copy/dev/pr-8415 Oct 15, 2025
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants