-
Notifications
You must be signed in to change notification settings - Fork 337
Adds comprehensive context key reference to docs #8420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5b289e1
Adds comprehensive context key reference to docs
faisalwaseem c3376ca
docs: Add comprehensive context key reference to documentation
faisalwaseem 40c6455
Add context key reference to documentation
faisalwaseem 19b8735
Merge branch 'dev' into doc-context-keylist
faisalwaseem 48b5b26
style: remove bold from codefont
mabuyo 1985604
minor clarification edits
mabuyo 64636e6
style: sentence-case headings, remove trailing spaces
mabuyo c6a281c
move duplicate info on context keys to reference page
mabuyo 06786ad
edit description
mabuyo e43791a
librarian edits: codefont booleans, edit awkward phrasing
mabuyo 6513053
Merge branch 'dev' into doc-context-keylist
faisalwaseem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| ### Adds comprehensive context key reference to docs ([PR #8420](https://github.com/apollographql/router/pull/8420)) | ||
|
|
||
| This change documents all the context keys router supports as of submitting this PR. | ||
|
|
||
| By [@faisalwaseem](https://github.com/faisalwaseem) in https://github.com/apollographql/router/pull/8420 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think something went wrong in the changeset here? I'm seeing a checklist that should only be in the PR description.
We can also remove this changeset because docs-only PRs typically don't need one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking, it's true that docs stuff doesn't need them, but I like to highlight really valuable documentation additions in our changesets, and I feel like this is one of them.
The changesets tooling defaults to the PR description that appears above the
<!-- start metadata -->line in the PR template, but since this PR had no description, it just defaulted to the entire PR contents.@faisalwaseem If you don't have time to fix the changeset, I can take a shot at it. Alternatively, agree to just delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with removing the changeset since the change is so minor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I did take a crack and fixing the changeset file lets see if that works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh thanks for clarifying Jesse! and looks like the changeset looks better now 🙌🏽 I'll go ahead and review the meat of the PR 👀