Skip to content

[Subgraph Insights] Promote Subgraph Metrics config to GA #8392

Merged
david-castaneda merged 4 commits intodevfrom
david/subgraph-insights-config-change
Oct 10, 2025
Merged

[Subgraph Insights] Promote Subgraph Metrics config to GA #8392
david-castaneda merged 4 commits intodevfrom
david/subgraph-insights-config-change

Conversation

@david-castaneda
Copy link
Contributor

@david-castaneda david-castaneda commented Oct 9, 2025

This PR removes the preview prefix from the Apollo telemetry subgraph_metrics config which is now GA.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@david-castaneda david-castaneda requested a review from a team October 9, 2025 15:57
@david-castaneda david-castaneda requested a review from a team as a code owner October 9, 2025 15:57
@apollo-librarian
Copy link

apollo-librarian bot commented Oct 9, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 7d3536c3eea3c435b94c14a0
Build Logs: View logs

@david-castaneda david-castaneda merged commit d87cba6 into dev Oct 10, 2025
15 checks passed
@david-castaneda david-castaneda deleted the david/subgraph-insights-config-change branch October 10, 2025 19:28
@@ -0,0 +1,11 @@
### [Subgraph Insights] Subgraph metrics config flag now GA ([PR #8200](https://github.com/apollographql/router/pull/8200))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-castaneda FYI this (and the bottom of the file) should be linking #8392 not #8200

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you're right. I'll can make a PR to fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #8472

@abernix abernix mentioned this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants