feat(coprocessor): Support per-stage coprocessor URLs#8384
Merged
Conversation
|
@cgati: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: 3fb2879470f5e12606dbc8c5 URL: https://www.apollographql.com/docs/deploy-preview/3fb2879470f5e12606dbc8c5 |
This comment has been minimized.
This comment has been minimized.
cgati
force-pushed
the
cgati/coprocessor-config
branch
3 times, most recently
from
bc5776a to
406e7ec
Compare
cgati
force-pushed
the
cgati/coprocessor-config
branch
from
406e7ec to
f4f2ae4
Compare
bnjjj
approved these changes
Oct 9, 2025
Contributor
bnjjj
left a comment
bnjjj
left a comment
There was a problem hiding this comment.
LGTM but could you apply suggestions made for docs ?
Member
|
Resolves #2821 |
BrynCooke
approved these changes
Oct 13, 2025
cgati
force-pushed
the
cgati/coprocessor-config
branch
2 times, most recently
from
839d14b to
2f10e3e
Compare
Adds the ability to configure different coprocessor URLs for each stage of request/response processing (router, supergraph, execution, subgraph). Each stage can now specify its own `url` field that overrides the global default URL. Changes: - Add optional `url` field to all stage configuration structs - Update all stage `as_service` methods to accept and resolve URLs - Add tests for URL validation and per-stage configuration Maintains full backward compatibility - existing configurations with a single global URL continue to work unchanged.
cgati
force-pushed
the
cgati/coprocessor-config
branch
from
2f10e3e to
75ec851
Compare
This was referenced Oct 27, 2025
Merged
10 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to configure different coprocessor URLs for each stage of request/response processing (router, supergraph, execution, subgraph). Each stage can now specify its own
urlfield that overrides the global default URL.Changes:
urlfield to all stage configuration structsas_servicemethods to accept and resolve URLsMaintains full backward compatibility - existing configurations with a single global URL continue to work unchanged.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩