fix(federation/query-planner): Avoid unnecessarily precomputing non-trivial followup edges#8373
Merged
sachindshinde merged 2 commits intodevfrom Oct 21, 2025
Conversation
This comment has been minimized.
This comment has been minimized.
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: f0263a1cf7b4d65dae2a49c7 |
sachindshinde
force-pushed
the
sachin/avoid-precomputing-non-trivial-followup-edges-for-subgraph-query-graphs
branch
from
469fc37 to
3e99c0b
Compare
Contributor
|
This change makes sense. I want to verify this is the problem via RTF before we commit this |
sachindshinde
deleted the
sachin/avoid-precomputing-non-trivial-followup-edges-for-subgraph-query-graphs
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently precompute non-trivial followup edge information for all query graph builders, so as to mirror the JS codebase. This is necessary when building federated query graphs and supergraph/API schema query graphs. However, this isn't needed when building subgraph query graphs (as
FederatedQueryGraphBuilder::build()does it later, and no graph paths are used in between).This PR accordingly updates
SchemaQueryGraphBuilder::build()to skip this precomputation if building a subgraph query graph, to avoid the unnecessary edge iteration/memory allocation. Note that this precomputation was originally skipped completely inSchemaQueryGraphBuilder::build()during query planning, but was introduced when aligning parity with the JS codebase in #7961.