Conversation
…r/src/metrics/mod.rs`
…_exporter Error class
…r` and `SpanExporterBuilder` became private
…Instrument, have global meter provider impl `From<MeterProvider`, fix macros
… longer exists in v0.27
Contributor
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 63 new, 10 changed, 0 removedBuild ID: b2f2d8d70ca5270dce2359de URL: https://www.apollographql.com/docs/deploy-preview/b2f2d8d70ca5270dce2359de |
TylerBloom
requested changes
Oct 1, 2025
| opentelemetry::Value::F64(v) => AttributeValue::F64(v), | ||
| opentelemetry::Value::String(v) => AttributeValue::String(v.into()), | ||
| opentelemetry::Value::Array(v) => AttributeValue::Array(v.into()), | ||
| _ => unreachable!(), |
Contributor
There was a problem hiding this comment.
Is this actually unreachable? What are the variants of Value?
Contributor
Author
There was a problem hiding this comment.
I think so:
pub enum Value {
/// bool values
Bool(bool),
/// i64 values
I64(i64),
/// f64 values
F64(f64),
/// String values
String(StringValue),
/// Array of homogeneous values
Array(Array),
}
Comment on lines
+22
to
+25
| mut _builder: MetricsBuilder, | ||
| _metrics_config: &MetricsCommon, | ||
| ) -> Result<MetricsBuilder, BoxError> { | ||
| if !self.enabled { | ||
| return Ok(builder); | ||
| } | ||
| let exporter_builder: MetricsExporterBuilder = self.exporter(TelemetryDataKind::Metrics)?; | ||
| let exporter = exporter_builder.build_metrics_exporter( | ||
| (&self.temporality).into(), | ||
| Box::new( | ||
| CustomAggregationSelector::builder() | ||
| .boundaries(metrics_config.buckets.clone()) | ||
| .build(), | ||
| ), | ||
| )?; | ||
| todo!("We can uncomment this when MetricExporterBuilder is re-exported in v0.30.0"); |
Contributor
There was a problem hiding this comment.
I admit that I recommended this solution; however, I had a misunderstanding. I was under the impression that each upgrade to versions between 0.24 up through 0.31 would be culminated in a single PR. I did not think that this upgrade would make it to dev. We should not commit open panics like this to dev.
Contributor
Author
There was a problem hiding this comment.
if I can't figure out a workaround, I won't merge this PR. I meant to just keep it in draft mode.
Contributor
There was a problem hiding this comment.
@meryl-c , thanks for the clarification. Sorry for any confusion I might have caused.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩