Trace and metrics exporter wrappers to append details to errors#8363
Merged
Trace and metrics exporter wrappers to append details to errors#8363
Conversation
Contributor
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: b8fce3fb9722fa6379b82d87 |
This comment has been minimized.
This comment has been minimized.
…l-error-messages' into njm/ROUTER-1283/otel-error-messages
6d86e23 to
d693ace
Compare
461df35 to
62b639c
Compare
BrynCooke
requested changes
Oct 9, 2025
Contributor
Author
I wasn't sure what NamedTokioRuntime was used for, but if it's just for this use-case I'll remove it. |
BrynCooke
approved these changes
Oct 10, 2025
| @@ -0,0 +1,5 @@ | |||
| ### Trace and metrics exporter wrappers to append details to errors ([PR #8363](https://github.com/apollographql/router/pull/8363)) | |||
|
|
|||
| Added a wrapper around `MetricsExporter`s and `SpanExporter`s so that the exporter type can be appended to error messages. This allows us to differentiate between e.g. "Apollo OTel" errors and "OTLP exporter" errors. | |||
Member
There was a problem hiding this comment.
Changesets should focus on end user impact. I'm guessing it would be something like this:
Suggested change
| Added a wrapper around `MetricsExporter`s and `SpanExporter`s so that the exporter type can be appended to error messages. This allows us to differentiate between e.g. "Apollo OTel" errors and "OTLP exporter" errors. | |
| Error messages raised during tracing and metrics exporting now indicate if the error occurred when exporting to Apollo Studio or to the user's configured OTLP endpoint. |
but it would also be helpful to clarify exactly how and why this is useful for customers
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a wrapper around
MetricsExporters andSpanExporters so that the exporter type can be appended to error messages. This allows us to differentiate between e.g. "Apollo OTel" errors and "OTLP exporter" errors.Error messages will now look like:
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩