Conversation
This comment has been minimized.
This comment has been minimized.
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 5 new, 3 changed, 0 removedBuild ID: a5a1f85c3aee2a747e060bae URL: https://www.apollographql.com/docs/deploy-preview/a5a1f85c3aee2a747e060bae |
33c3b78 to
d442d4c
Compare
\# Main Changes * Sidebar Updates: Restructures and adds links to the new documentaion. * New Documentation: * Connecting to Datadog: Explains various connection methods (e.g., OpenTelemetry Collector, Datadog Agent). * Dashboard Template: Provides instructions for using preconfigured Datadog dashboards. * Router Instrumentation: Details settings for enhancing APM views, including error tracking and resource naming. * OpenTelemetry Collector Configuration: Comprehensive guide on setting up the collector. * Enhancements to Existing Documentation: * Added links to new documentation to drive home the organization. * Move some router instrumentation from the datadog-agent-traces page to the new router-instrumentation page. \# Noteworthy * I explicitly mentioned ddot and agentless as methods to connect to Datadog, despite the fact that our own documentation for these methods is not yet available. Agentless support is currently in the backlog, and ddot requires a combination of OTEL collector and agent configurations. In the interim, the combined documentation from Datadog and our own will be sufficient. Co-authored-by: Isaac M. Good <imgood@apollographql.com>
d442d4c to
b346521
Compare
mabuyo
left a comment
There was a problem hiding this comment.
These guides are really great, thanks team! I don't have much subject matter knowledge here so recommend having an SME review for technical accuracy. My review focused on navigating around and information structure.
Do we also need to add anything in the YAML config doc for telemetry? https://www.apollographql.com/docs/graphos/routing/configuration/yaml#telemetry
...uting/observability/router-telemetry-otel/apm-guides/datadog/connecting-to-datadog/index.mdx
Show resolved
Hide resolved
docs/source/routing/observability/router-telemetry-otel/apm-guides/datadog/index.mdx
Outdated
Show resolved
Hide resolved
...uting/observability/router-telemetry-otel/apm-guides/datadog/connecting-to-datadog/index.mdx
Outdated
Show resolved
Hide resolved
...uting/observability/router-telemetry-otel/apm-guides/datadog/connecting-to-datadog/index.mdx
Outdated
Show resolved
Hide resolved
...uting/observability/router-telemetry-otel/apm-guides/datadog/connecting-to-datadog/index.mdx
Outdated
Show resolved
Hide resolved
...uting/observability/router-telemetry-otel/apm-guides/datadog/connecting-to-datadog/index.mdx
Outdated
Show resolved
Hide resolved
...ce/routing/observability/router-telemetry-otel/apm-guides/datadog/router-instrumentation.mdx
Outdated
Show resolved
Hide resolved
...ce/routing/observability/router-telemetry-otel/apm-guides/datadog/router-instrumentation.mdx
Outdated
Show resolved
Hide resolved
...ce/routing/observability/router-telemetry-otel/apm-guides/datadog/router-instrumentation.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Michelle Mabuyo <michelle@apollographql.com>
583c6fe to
325bd56
Compare
lrlna
left a comment
There was a problem hiding this comment.
I think this needs a few small corrections, but is overall looking really good!
...ce/routing/observability/router-telemetry-otel/apm-guides/datadog/router-instrumentation.mdx
Outdated
Show resolved
Hide resolved
...ce/routing/observability/router-telemetry-otel/apm-guides/datadog/router-instrumentation.mdx
Outdated
Show resolved
Hide resolved
...ce/routing/observability/router-telemetry-otel/apm-guides/datadog/router-instrumentation.mdx
Outdated
Show resolved
Hide resolved
...ce/routing/observability/router-telemetry-otel/apm-guides/datadog/router-instrumentation.mdx
Outdated
Show resolved
Hide resolved
...ce/routing/observability/router-telemetry-otel/apm-guides/datadog/router-instrumentation.mdx
Outdated
Show resolved
Hide resolved
...ervability/router-telemetry-otel/apm-guides/datadog/connecting-to-datadog/otel-collector.mdx
Outdated
Show resolved
Hide resolved
...ervability/router-telemetry-otel/apm-guides/datadog/connecting-to-datadog/otel-collector.mdx
Outdated
Show resolved
Hide resolved
...ervability/router-telemetry-otel/apm-guides/datadog/connecting-to-datadog/otel-collector.mdx
Outdated
Show resolved
Hide resolved
...ervability/router-telemetry-otel/apm-guides/datadog/connecting-to-datadog/otel-collector.mdx
Outdated
Show resolved
Hide resolved
…er instrumentation documentation
Co-authored-by: Iryna Shestak <shestak.irina@gmail.com>
Co-authored-by: Iryna Shestak <shestak.irina@gmail.com>
Co-authored-by: Iryna Shestak <shestak.irina@gmail.com>
...ervability/router-telemetry-otel/apm-guides/datadog/connecting-to-datadog/otel-collector.mdx
Outdated
Show resolved
Hide resolved
...ervability/router-telemetry-otel/apm-guides/datadog/connecting-to-datadog/otel-collector.mdx
Outdated
Show resolved
Hide resolved
mabuyo
left a comment
There was a problem hiding this comment.
Left some last minor comments but overall looks great! Thank you! 🙌🏽
Co-authored-by: Michelle Mabuyo <michelle@apollographql.com>
Co-authored-by: Michelle Mabuyo <michelle@apollographql.com>
lrlna
left a comment
There was a problem hiding this comment.
Thank you! These are going to be heaps helpful
Summary
This Pull Request introduces updates to the Datadog integration documentation for the Apollo Router. The changes aim to provide clearer, more structured instructions for setting up telemetry with Datadog, expanding on connection methods, configuration guides, and monitoring capabilities.
Main Changes
Note worthy
RR-305
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
This is a docs only PR. Checklist items around Unit testing and router compatibility need not appy.