fix: force aggregate temporarility for updown counters#8174
Merged
Conversation
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 2 changed, 0 removedBuild ID: 345ed333abb9994b7e00a85d URL: https://www.apollographql.com/docs/deploy-preview/345ed333abb9994b7e00a85d |
This comment has been minimized.
This comment has been minimized.
When providing functionality to override the temporarilty selector for OTLP export we did not take into account that updown counters are always aggregate rather than delta. This now restores the aggregation with that of the regular OTLP exporter.
BrynCooke
force-pushed
the
bryn/up_down_counters
branch
from
d1c411c to
cb62a42
Compare
BrynCooke
force-pushed
the
bryn/up_down_counters
branch
from
5798a85 to
7174adc
Compare
added 3 commits
September 2, 2025 16:57
BrynCooke
force-pushed
the
bryn/up_down_counters
branch
from
4b0d666 to
75ac35c
Compare
bnjjj
approved these changes
Sep 3, 2025
goto-bus-stop
requested changes
Sep 3, 2025
Contributor
Author
There was a problem hiding this comment.
Oops, I had some integration tests earlier but they seemed like overkill.
ffcf40f
This reverts commit c048c5c.
goto-bus-stop
approved these changes
Sep 3, 2025
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When providing functionality to override the temporarilty selector for OTLP export we did not take into account that updown counters are always aggregate rather than delta. This now restores the aggregation with that of the regular OTLP exporter.
Note that this won't fix drift that may occur over reloads. This will be tackled separately.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩