Report PQ usage when an operation is requested by safelisted operation body#8168
Merged
Report PQ usage when an operation is requested by safelisted operation body#8168
Conversation
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 7e0d60c1aa32c51f1be5bbd8 |
30b634d to
7f2fb8c
Compare
7f2fb8c to
f0e39ac
Compare
timbotnik
reviewed
Sep 2, 2025
Contributor
timbotnik
left a comment
There was a problem hiding this comment.
Changes look good - wondering if there were any other Apollo metrics tests that could be updated to validate that the PQ ID is captured in this scenario?
93e7a55 to
b3c45e2
Compare
timbotnik
approved these changes
Sep 2, 2025
Contributor
timbotnik
left a comment
There was a problem hiding this comment.
Thx for the extra tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would only record PQ metrics for operations that were requested by the PQ ID. This change updates usage reporting so that we also report usage if the PQ operation is requested by the safelisted operation body.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩