Skip to content

Report PQ usage when an operation is requested by safelisted operation body#8168

Merged
bonnici merged 6 commits intodevfrom
njm/P-1761/pq-report-by-body
Sep 2, 2025
Merged

Report PQ usage when an operation is requested by safelisted operation body#8168
bonnici merged 6 commits intodevfrom
njm/P-1761/pq-report-by-body

Conversation

@bonnici
Copy link
Contributor

@bonnici bonnici commented Sep 1, 2025

Previously we would only record PQ metrics for operations that were requested by the PQ ID. This change updates usage reporting so that we also report usage if the PQ operation is requested by the safelisted operation body.

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@bonnici bonnici requested a review from a team September 1, 2025 06:32
@apollo-librarian
Copy link

apollo-librarian bot commented Sep 1, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 7e0d60c1aa32c51f1be5bbd8
Build Logs: View logs

@bonnici bonnici force-pushed the njm/P-1761/pq-report-by-body branch from 30b634d to 7f2fb8c Compare September 1, 2025 06:36
@bonnici bonnici force-pushed the njm/P-1761/pq-report-by-body branch from 7f2fb8c to f0e39ac Compare September 1, 2025 06:47
@bonnici bonnici marked this pull request as ready for review September 1, 2025 06:56
@bonnici bonnici requested a review from a team September 1, 2025 06:56
@bonnici bonnici requested a review from a team as a code owner September 1, 2025 06:56
Copy link
Contributor

@timbotnik timbotnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - wondering if there were any other Apollo metrics tests that could be updated to validate that the PQ ID is captured in this scenario?

@bonnici bonnici force-pushed the njm/P-1761/pq-report-by-body branch from 93e7a55 to b3c45e2 Compare September 2, 2025 04:03
Copy link
Contributor

@timbotnik timbotnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the extra tests!

@bonnici bonnici merged commit 0ec3aa7 into dev Sep 2, 2025
15 checks passed
@bonnici bonnici deleted the njm/P-1761/pq-report-by-body branch September 2, 2025 05:32
@abernix abernix mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants